Fix various opt-group handling issues #1200

Xon · 2024-09-05T05:04:19Z

Fix refresh() did not work properly with opt-groups
Fix group-id was not added to choices outside of search
Fix opt-group e2e tests false positive
Fix removing a choice didn't work properly when it was part of a group
Fix regression of choices without groups where not rendered when groups where present

…t suppression

…ypescript-eslint/no-explicit-any

…ps where present

Xon added 11 commits September 5, 2024 11:42

De-dupe type, and remove broad @typescript-eslint/no-explicit-any lin…

177a4a3

…t suppression

_getChoiceForOutput never gets an undefined value

65e6db1

Fix typing for getValue, which removes the need for eslint-disable @t…

ba33087

…ypescript-eslint/no-explicit-any

Fix refresh() did not work properly with opt-groups

5661098

Fix missing tag in e2e test html

ccf40c3

Fix group-id was not added to choices outside of search

93531ab

Fix opt-group e2e tests false positive

8a12d5c

Use group reference instead of groupId

8c56acb

Fix removing a choice didn't work properly when it was part of a group

6b77671

Fix regression of choices without groups where not rendered when grou…

ecc21a3

…ps where present

cleanup tests

59f7d67

Xon added the bugfix Pull request that fixes an existing bug label Sep 5, 2024

Xon self-assigned this Sep 5, 2024

Xon changed the title ~~Fix opt-group handling~~ Fix various opt-group handling issues Sep 5, 2024

Xon merged commit d0a7e70 into main Sep 5, 2024
10 checks passed

Xon deleted the opt-group_fix branch September 5, 2024 05:22

Provide feedback