Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various opt-group handling issues #1200

Merged
merged 11 commits into from
Sep 5, 2024
Merged

Fix various opt-group handling issues #1200

merged 11 commits into from
Sep 5, 2024

Commits on Sep 5, 2024

  1. De-dupe type, and remove broad @typescript-eslint/no-explicit-any lin… 

    …t suppression
    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    177a4a3 View commit details
    Browse the repository at this point in the history

  2. _getChoiceForOutput never gets an undefined value

    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    65e6db1 View commit details
    Browse the repository at this point in the history

  3. Fix typing for getValue, which removes the need for eslint-disable @t… 

    …ypescript-eslint/no-explicit-any
    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ba33087 View commit details
    Browse the repository at this point in the history

  4. Fix refresh() did not work properly with opt-groups

    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5661098 View commit details
    Browse the repository at this point in the history

  5. Fix missing tag in e2e test html

    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ccf40c3 View commit details
    Browse the repository at this point in the history

  6. Fix group-id was not added to choices outside of search

    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    93531ab View commit details
    Browse the repository at this point in the history

  7. Fix opt-group e2e tests false positive

    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8a12d5c View commit details
    Browse the repository at this point in the history

  8. Use group reference instead of groupId

    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8c56acb View commit details
    Browse the repository at this point in the history

  9. Fix removing a choice didn't work properly when it was part of a group

    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    6b77671 View commit details
    Browse the repository at this point in the history

  10. Fix regression of choices without groups where not rendered when grou… 

    …ps where present
    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ecc21a3 View commit details
    Browse the repository at this point in the history

  11. cleanup tests

    @Xon
    Xon committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    59f7d67 View commit details
    Browse the repository at this point in the history