Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump TIDDIT version #1470

Open
wants to merge 38 commits into
base: develop
Choose a base branch
from
Open

chore: Bump TIDDIT version #1470

wants to merge 38 commits into from

Conversation

ivadym
Copy link
Contributor

@ivadym ivadym commented Aug 6, 2024

Description

Changed

  • Upgrade TIDDIT to latest version

Documentation

  • N/A
  • Updated Balsamic documentation to reflect the changes as needed for this PR.
    • Update TIDDIT version

Tests

Feature Tests

  • varcall_py3 container integrity
  • TIDDIT SV calling

Pipeline Integrity Tests

  • Report deliver (generation of the .hk file)
    • N/A
    • Verified
  • TGA T/O Workflow
    • N/A
    • Verified
  • TGA T/N Workflow
    • N/A
    • Verified
  • UMI T/O Workflow
    • N/A
    • Verified
  • UMI T/N Workflow
    • N/A
    • Verified
  • WGS T/O Workflow
    • N/A
    • Verified
  • WGS T/N Workflow
    • N/A
    • Verified
  • QC Workflow
    • N/A
    • Verified
  • PON Workflow
    • N/A
    • Verified

Clinical Genomics Stockholm

Documentation

  • Atlas documentation
    • N/A
    • Updated: [Link]
  • Web portal for Clinical Genomics
    • N/A
    • Updated: [Link]

Panel of Normal specific criteria

User Changes

  • N/A
  • This PR affects the output files or results.
    • User feedback is considered unnecessary because we're only updating the version of the tool.
    • Affected users have been included in the development process and given a chance to provide feedback.

Infrastructure Changes

  • Stored files in Housekeeper
    • N/A
    • Updated: [Link]
  • CG (CLI and delivered/uploaded files)
    • N/A
    • Updated: [Link]
  • Servers (configuration files on Hasta)
    • N/A
    • Updated: [Link]
  • Scout interface
    • N/A
    • Updated: [Link]

Checklist

Important

Ensure that all checkboxes below are ticked before merging.

For Developers

  • PR Description
    • Provided a comprehensive description of the PR.
    • Linked relevant user stories or issues to the PR.
  • Documentation
    • Verified and updated documentation if necessary.
  • Tests
    • Described and tested the functionality addressed in the PR.
    • Ensured integration of the new code with existing workflows.
    • Confirmed that meaningful unit tests were added for the changes introduced.
    • Checked that the PR has successfully passed all relevant code smells and coverage checks.
  • Review
    • Addressed and resolved all the feedback provided during the code review process.
    • Obtained final approval from designated reviewers.

For Reviewers

  • Code
    • Code implements the intended features or fixes the reported issue.
    • Code follows the project's coding standards and style guide.
  • Documentation
    • Pipeline changes are well-documented in the CHANGELOG and relevant documentation.
  • Tests
    • The author provided a description of their manual testing, including consideration of edge cases and boundary
      conditions where applicable, with satisfactory results.
  • Review
    • Confirmed that the developer has addressed all the comments during the code review.

@ivadym ivadym requested a review from a team as a code owner August 6, 2024 09:38
@ivadym ivadym changed the base branch from master to develop August 6, 2024 09:38
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (7d529e6) to head (c68d177).
Report is 13 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1470   +/-   ##
========================================
  Coverage    99.48%   99.48%           
========================================
  Files           40       40           
  Lines         1932     1957   +25     
========================================
+ Hits          1922     1947   +25     
  Misses          10       10           
Flag Coverage Δ
unittests 99.48% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ivadym ivadym added this to the Release 16 milestone Aug 6, 2024
@mathiasbio
Copy link
Collaborator

Ah! Nice 🙏 Sorry I missed this. Looks good, except that I'm curious about these failing container builds 🫠 I imagine that we will have this issue even if we don't update TIDDIT right? We just need to fix the container I imagine

Copy link
Collaborator

@mathiasbio mathiasbio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! 🙏 🌟

@ivadym
Copy link
Contributor Author

ivadym commented Aug 6, 2024

Ah! Nice 🙏 Sorry I missed this. Looks good, except that I'm curious about these failing container builds 🫠 I imagine that we will have this issue even if we don't update TIDDIT right? We just need to fix the container I imagine

Yep, I'll look into it tomorrow. Haven't tested the Python 3 container yet, so there might be more surprises 😓

BALSAMIC/containers/varcall_py3/Dockerfile Dismissed Show resolved Hide resolved
Copy link

@ivadym ivadym linked an issue Aug 14, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[User Story] Update TIDDIT to make use of single-end reads
2 participants