Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ApplicationWorkHistoryBreak#application_form_id #9732

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

CatalinVoineag
Copy link
Contributor

@CatalinVoineag CatalinVoineag commented Aug 21, 2024

Context

We don't need the application_form_id on the
application_work_history_break table, we use the breakable column to
link it to an application form.

This commit ignores the application_form_id and makes sure the deletion
of the history break is going to happen when deleting a candidate, just
like before.

We made application_form_id nullable here
9d60480

Changes proposed in this pull request

Ignore application_form_id
Delete application_work_history_break when the candidate is deleted. Cascading deletes don't work with polymorphic relations.

Guidance to review

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@CatalinVoineag
Copy link
Contributor Author

We don't need the application_form_id on the
application_work_history_break table, we use the breakable column to
link it to an application form.

This commit ignores the application_form_id and makes sure the deletion
of the history break is going to happen when deleting a candidate, just
like before.

We made application_form_id nullable here
9d60480
@CatalinVoineag CatalinVoineag force-pushed the cv/ignore-application-form-id-on-breaks branch from 874221f to 6c953c3 Compare August 21, 2024 11:00
@CatalinVoineag CatalinVoineag marked this pull request as ready for review August 21, 2024 11:16
@CatalinVoineag CatalinVoineag requested a review from a team August 21, 2024 11:16
@CatalinVoineag CatalinVoineag merged commit e0e9795 into main Aug 21, 2024
24 checks passed
@CatalinVoineag CatalinVoineag deleted the cv/ignore-application-form-id-on-breaks branch August 21, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants