-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: adding tidytable support #271
base: master
Are you sure you want to change the base?
Conversation
Interesting. Those examples work outside of {disk.frame}, I wonder what's causing the issue. I'll take a look at {tidytable} as well and see if I can find anything |
Actually, the below seems to work, so we probably not that far from an integration! Group-by are a bit trickier, but can be done. As you can see, integrating many of funcitons like fn = function(a, b) {
a+b
}
dt_mutate = disk.frame::create_chunk_mapper(tidytable::dt_mutate)
library(disk.frame)
value = as.disk.frame(data.frame(num = runif(1e6)))
df3 = value %>%
dt_mutate(b = fn(num, num)) %>%
collect
df3 |
Nice! Glad it's looking like it will work |
This doesn't work fn = function(a, b) {
a+b
}
dt_mutate = disk.frame::create_chunk_mapper(tidytable::dt_mutate)
library(disk.frame)
setup_disk.frame() # this makes it fail
value = as.disk.frame(data.frame(num = runif(1e6)))
df3 = value %>%
dt_mutate(b = fn(num, num)) %>%
collect
df3 |
In the latest branch of disk.frame; this works flawlessly library(tidytable)
library(disk.frame)
setup_disk.frame(2)
fn <- function(a,b) a+b
mutate..disk.frame = create_chunk_mapper(tidytable::mutate.)
value = as.disk.frame(data.frame(num = runif(1e6)))
df3 = value %>%
mutate.(b = fn(num, num)) %>%
collect So should be doable soon |
Hi, any updates regarding this branch? |
this is pending updates to the disk.frame NSE mechanism. |
Adding some tests, it seems that tidytable works quite different to dplyr to the point where
the below doesn't work with {disk.frame} but the dplyr equivalent does. It seems that obtaining some function or variables from the environment is not working
This is either a {disk.frame} issue or an implementation detail of tidytable. Need to investigate