Fire PotionSplashEvent #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #922
PotionSplashEvent is now fired whenever a splash potion lands (including a lingering potion, but only for immediate effects). In addition to cancelation, we also recognize changes to the list of targets and the intensity for each target. In the case of a potion of healing, EntityRegainHealthEvent is also fired for each target, using the same logic that
GlowPlayer.pulse()already uses when regenerating from food; that logic is nowEntityUtils.heal(LivingEntity, double, EntityRegainHealthEvent.RegainReason).Partial-intensity effects for splash potions and lingering potions are now implemented. For custom instant effects at level 2 or higher, partial intensity may mean a lower level.