-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure safe_to_tensor moves tensors to the specified device. #831
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #831 +/- ##
==========================================
+ Coverage 95.69% 95.71% +0.02%
==========================================
Files 102 102
Lines 9645 9646 +1
==========================================
+ Hits 9230 9233 +3
+ Misses 415 413 -2 ☔ View full report in Codecov by Sentry. |
563bccf
to
7474c6c
Compare
02d1c17
to
7e618b0
Compare
I think the coverage warning in this one is spurious. Can you merge this @AdamGleave ? |
Looks like the issue is that |
Hello, what's the state of this PR? |
This PR fixes a bug in the
safe_to_tensor
utility: previously it did not move tensors to a new device according to thedevice
kwarg which caused issues when there is more than one device available.The bug went unnoticed for a long while since our circleCI runners do not have GPUs enabled.
Thanks to @tomtseng for drafting a fix for this in #828