Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show Success Transfer view #38

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

valentinperignon
Copy link
Member

@valentinperignon valentinperignon commented Nov 5, 2024

Depends on #36

@valentinperignon valentinperignon changed the base branch from main to feat-upload-in-progress November 5, 2024 17:22
Copy link

github-actions bot commented Nov 5, 2024

Found 1 unused code occurences

Expand

Copy link

github-actions bot commented Nov 8, 2024

This PR/issue depends on:

@valentinperignon valentinperignon marked this pull request as ready for review November 8, 2024 11:18
Copy link

sonarcloud bot commented Nov 11, 2024

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of two TODO it is good for me.
Feel free to close conversations and merge it if it is fine with you.

@valentinperignon valentinperignon merged commit 25e4ddb into feat-upload-in-progress Nov 12, 2024
3 of 4 checks passed
@valentinperignon valentinperignon deleted the feat-show-success branch November 12, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants