Add confirm text #243
Closed
Add confirm text #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2023 10:40
default "Submit query".
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/KeithWM/PlutoUI.jl", rev="add-confirm-text")
julia> using PlutoUIOr run this code in your browser: |
|
The current behaviour is to let the user agent choose a text, according to localization settings. We want to maintain this behaviour, at least as the default one. Could you adjust the default to fall back to this behaviour and only override if you explicitly pass some text? |
|
Hi Panagiotis, Good idea! I will adjust it and update the PR. Keith |
genericallyterrible
added a commit
to genericallyterrible/PlutoUI.jl
that referenced
this pull request
Feb 21, 2024
Supersedes JuliaPluto#243
genericallyterrible
added a commit
to genericallyterrible/PlutoUI.jl
that referenced
this pull request
Feb 21, 2024
Supersedes JuliaPluto#243
|
Wow I really dropped the ball there, thanks for picking it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to add a custom text to a "Confirm" button. Currently it showed the rather unfriendly "Submit Query" text on my setup (might be OS/browser dependent?). It now shows the text "Confirm" by default, but the user can specify a different text by use of an optional (non-keyword) argument.
I hope you like it, but am happy to make any changes as you see fit.