Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional label kwarg to confirm #294

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

genericallyterrible
Copy link
Contributor

Respects user agent by default, allows user to override the submit button's value with the label kwarg.

Supersedes #243

image

Copy link

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/genericallyterrible/PlutoUI.jl", rev="add-confirm-label")
julia> using PlutoUI

Or run this code in your browser: Run with binder

@fonsp
Copy link
Member

fonsp commented Feb 22, 2024

Awesome! Thanks for the very nice implementation ☺️

@fonsp fonsp merged commit 2b27235 into JuliaPluto:main Feb 22, 2024
4 checks passed
@genericallyterrible genericallyterrible deleted the add-confirm-label branch February 22, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants