Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kover to 0.9.0-RC, Add Coverage Report to CI, and Consolidate Workflows #673

Merged
merged 8 commits into from
Nov 24, 2024

Conversation

matt-ramotar
Copy link
Collaborator

@matt-ramotar matt-ramotar commented Nov 17, 2024

This PR is:

  • Updating Kover to 0.9.0-RC
  • Generating coverage report on check and uploading to Codecov
  • Consolidating CI workflows

My goal is to get our coverage above 90%. Will start chipping away at uncovered code after this merges.

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
@tyvsmith
Copy link
Member

You're on an old version of Kover, and they made some improvements, including better detection of certain constants patterns that don't need coverage.

Recommend updating to latest stable (or check out rc build), as well as looking into any central exclusions that would make sense for the project wide.

- uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./kover/coverage.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the coverage file being treated as generated code in PR review process already? If not, that should be added to the .gitattributes file so it doesn't create additional noise.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout, thanks. We were previously checking it in. Removed coverage reports from the repo, updated our .gitignore, and modified our workflows accordingly.

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
… fetch all history and tags

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (12f1212) to head (c68626f).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   67.23%   75.32%   +8.08%     
==========================================
  Files          39       38       -1     
  Lines         934      920      -14     
  Branches      194      169      -25     
==========================================
+ Hits          628      693      +65     
+ Misses        205      142      -63     
+ Partials      101       85      -16     

see 17 files with indirect coverage changes

---- 🚨 Try these New Features:

@matt-ramotar matt-ramotar changed the title Run codecov on PR and push Update Kover to 0.9.0-RC, Add Coverage Report to CI, and Consolidate Workflows Nov 24, 2024
@matt-ramotar matt-ramotar merged commit bd0ce82 into main Nov 24, 2024
5 checks passed
@matt-ramotar matt-ramotar deleted the matt-ramotar/codecov branch November 24, 2024 05:25
matt-ramotar added a commit that referenced this pull request Nov 24, 2024
…Workflows (#673)

* Run codecov on PR and push

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Use codecov-action@v4 with CODECOV_TOKEN

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Remove coverage files

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Update .gitignore

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Update kover to 0.9.0-RC

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Consolidate workflows

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Update workflow to check out the repository on the correct branch and fetch all history and tags

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

* Format

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>

---------

Signed-off-by: matt-ramotar <matt.ramotar@uber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants