Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kover to 0.9.0-RC, Add Coverage Report to CI, and Consolidate Workflows #673

Merged
merged 8 commits into from
Nov 24, 2024
Merged

Update Kover to 0.9.0-RC, Add Coverage Report to CI, and Consolidate Workflows #673

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f9379b2
Run codecov on PR and push
matt-ramotar Nov 17, 2024
dfbac12
Use codecov-action@v4 with CODECOV_TOKEN
matt-ramotar Nov 18, 2024
d802a8b
Remove coverage files
matt-ramotar Nov 24, 2024
159014c
Update .gitignore
matt-ramotar Nov 24, 2024
30bbb47
Update kover to 0.9.0-RC
matt-ramotar Nov 24, 2024
5f71f5a
Consolidate workflows
matt-ramotar Nov 24, 2024
b2c387d
Update workflow to check out the repository on the correct branch and…
matt-ramotar Nov 24, 2024
c68626f
Format
matt-ramotar Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
coverage:
range: 50..80
range: 70..80
round: down
precision: 2

Expand Down
12 changes: 1 addition & 11 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,4 @@ jobs:
- name: Setup Gradle
uses: gradle/actions/setup-gradle@v3
- name: Run check with Gradle Wrapper
run: ./gradlew check

coverage:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: codecov/codecov-action@v3
with:
files: ./kover/coverage.xml
name: codecov-umbrella
verbose: true
run: ./gradlew check
13 changes: 13 additions & 0 deletions .github/workflows/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
name: Codecov
on: [ push, pull_request ]
jobs:
run:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./kover/coverage.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the coverage file being treated as generated code in PR review process already? If not, that should be added to the .gitattributes file so it doesn't create additional noise.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout, thanks. We were previously checking it in. Removed coverage reports from the repo, updated our .gitignore, and modified our workflows accordingly.

name: codecov-umbrella
verbose: true
Loading