Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): add validation rules to salesforce fetch-fields #17

Merged
merged 5 commits into from
Sep 30, 2024

Conversation

hassan254-prog
Copy link
Contributor

@hassan254-prog hassan254-prog commented Sep 27, 2024

Describe your changes

  • Small change to the salesforce fetch-fields action to also retrieve the validation rules.

Issue ticket number and link

EXT-148

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set

Copy link

linear bot commented Sep 27, 2024

@hassan254-prog hassan254-prog marked this pull request as draft September 27, 2024 09:42
@khaliqgant
Copy link
Member

You should commit the mock files @hassan254-prog

@hassan254-prog
Copy link
Contributor Author

hassan254-prog commented Sep 27, 2024

You should commit the mock files @hassan254-prog

Adding mock data for the other syncs to ensure all tests pass.

@khaliqgant
Copy link
Member

You should commit the mock files @hassan254-prog

Adding mock data for the other syncs to ensure all tests pass.

Thanks, looks like you need to save done the mock data again via the --save-responses flag @hassan254-prog

@hassan254-prog
Copy link
Contributor Author

You should commit the mock files @hassan254-prog

Adding mock data for the other syncs to ensure all tests pass.

Thanks, looks like you need to save done the mock data again via the --save-responses flag @hassan254-prog

I've placed it in draft mode to incorporate the new changes.

@hassan254-prog hassan254-prog marked this pull request as ready for review September 30, 2024 10:18
@khaliqgant khaliqgant merged commit 62ce214 into main Sep 30, 2024
5 checks passed
@khaliqgant khaliqgant deleted the wari/ext-148-salesforce-action branch September 30, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants