2.16 faster flake lock parsing #10183
Conversation
This PR reduces the creation of short-lived basic_json objects while parsing flake.lock files. For large flake.lock files (~1.5MB) I was observing ~60s being spent for trivial nix build operations while after this change it is now taking ~1.6s. (cherry picked from commit 7fd0de3)
|
We normally don't backport beyond the default Nix of NixOS stable (ie NixOS 23.11, Nix 2.18). Do you really need this? |
|
Thanks for your attention @roberth . Unfortunately, I work with a large number of users, some of whom are unable to update past But, it would make sense (considering the scope/risk of the change weighed against the performance benefit) to backport this all the way to Alternatively (but not ideally), a |
|
Successfully created backport PR for |
|
Git push to origin failed for 2.4-maintenance with exitcode 1 |
|
Successfully created backport PR for |
|
Git push to origin failed for 2.4-maintenance with exitcode 1 |
|
Successfully created backport PR for |
|
Git push to origin failed for 2.15-maintenance with exitcode 1 |
|
Git push to origin failed for 2.4-maintenance with exitcode 1 |
|
Successfully created backport PR for |
|
Git push to origin failed for 2.14-maintenance with exitcode 1 |
|
Git push to origin failed for 2.15-maintenance with exitcode 1 |
|
Git push to origin failed for 2.4-maintenance with exitcode 1 |
|
Successfully created backport PR for |
|
Git push to origin failed for 2.13-maintenance with exitcode 1 |
|
Git push to origin failed for 2.14-maintenance with exitcode 1 |
|
Git push to origin failed for 2.15-maintenance with exitcode 1 |
|
Git push to origin failed for 2.4-maintenance with exitcode 1 |
|
Successfully created backport PR for |
|
Git push to origin failed for 2.12-maintenance with exitcode 1 |
|
Git push to origin failed for 2.13-maintenance with exitcode 1 |
|
Git push to origin failed for 2.14-maintenance with exitcode 1 |
|
Git push to origin failed for 2.15-maintenance with exitcode 1 |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
Motivation
This is the same as #10055 #10170 #10057 #10169 but for
2.16-maintenance.I'd also ask for this to be backported to
2.15-maintenance2.14-maintenance2.13-maintenance2.12-maintenance2.11-maintenance2.10-maintenance2.9-maintenance2.8-maintenance2.7-maintenance2.6-maintenance2.5-maintenance2.4-maintenanceContext
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.