Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.10-maintenance] 2.16 faster flake lock parsing #10191

Closed

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Mar 7, 2024

Automatic backport to 2.10-maintenance, triggered by a label in #10183.

This PR reduces the creation of short-lived basic_json objects while
parsing flake.lock files. For large flake.lock files (~1.5MB) I was
observing ~60s being spent for trivial nix build operations while
after this change it is now taking ~1.6s.

(cherry picked from commit 7fd0de3)
(cherry picked from commit f94fb63)
@thufschmitt
Copy link
Member

This targets an unsupported Nix release. The CI is broken there and I'd rather keep the sub-efficient behavior than merging something untested. So closing

@thufschmitt thufschmitt closed this Mar 8, 2024
auto-merge was automatically disabled March 8, 2024 09:35

Pull request was closed

@edolstra edolstra deleted the backport-10183-to-2.10-maintenance branch March 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant