Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor maintenance fixes #88

Merged
merged 6 commits into from
Jan 30, 2024
Merged

Minor maintenance fixes #88

merged 6 commits into from
Jan 30, 2024

Conversation

pavel-kirienko
Copy link
Member

@pavel-kirienko pavel-kirienko commented Jan 30, 2024

  • Update contributing instructions
  • Fix the CYPHAL_VERSION/CETL_VERSION mixup
  • Remove unnecessary assignment of FETCHCONTENT_FULLY_DISCONNECTED with a misleading warning message
  • Fix ./verify.py --version
  • Fix invalid indentation in verify.py (I would rather use Black)
  • Add JetBrains items to .gitignore

Fixes #87

Disregard the name of the branch.

…n Java 11 which is no longer supported. Also update the checkout actions to v4 because v3 uses a deprecated version of node. Keep the cache and artifact upload/download actions as-is because there are breaking changes involved in v4; changing these is not a priority and requires Scott's blessing anyway.
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@thirtytwobits thirtytwobits merged commit eff2a6d into main Jan 30, 2024
30 checks passed
@thirtytwobits thirtytwobits deleted the issue51 branch January 30, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing instructions are broken
2 participants