Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗🔧：correct file extensions of adrs & comply w/ ruleset #703

Merged
merged 23 commits into from
Feb 6, 2024
Merged

🏗🔧：correct file extensions of adrs & comply w/ ruleset #703

merged 23 commits into from
Feb 6, 2024

Conversation

DerekNonGeneric
Copy link
Member

Pull Request Purpose

Make a selection on the purpose(s) of your changes.

This PR contains the following:

  • 🐞🔧 bugfixing (🐜/🦟/🐛/🦗/🐝 et al.)
  • 🆕🎏 implementation of new feature(s)
  • ♻️ refactoring(s)
  • 📄 documentation modification(s)
  • 🔮 other

Testing

Have you included any tests in your submission?

  • yes (bugfixes and features will not be merged without
    tests    )
  • no

Breaking Changes

Have you modified any aspect public API surface (i.e., caused breakage)?

  • yes (breaking changes will not be merged unless
    necessary    )
  • no

Description

A concise recap summarily detailing what all are the changes being made.

List of any relevant issue numbers:

@DerekNonGeneric DerekNonGeneric added documentation Improvements or additions to documentation question Further information is requested tools Issues and PRs related to the tools directory linting Issues and PRs that deal with linting content Related to creating / editing content testing infrastructure discuss Issues opened for discussions and feedbacks markdown An issue or PR related to Markdown fast-track PRs that do not need to wait for 48 hours to land 🔧 Type: Maintenance undefined 🌘 P3: Low undefined labels Feb 6, 2024
@DerekNonGeneric DerekNonGeneric requested review from OpenINFbot and a team February 6, 2024 04:05
@DerekNonGeneric DerekNonGeneric force-pushed the fix/adr-file-exts branch 4 times, most recently from 817c1b0 to 08944af Compare February 6, 2024 07:33
@socket-security Socket Security
Copy link

socket-security bot commented Feb 6, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/retext-equality@7.0.0, npm/retext-profanities@8.0.0

View full report↗︎

@DerekNonGeneric DerekNonGeneric force-pushed the fix/adr-file-exts branch 4 times, most recently from 4a17460 to d07593d Compare February 6, 2024 09:24
OpenINFbot
OpenINFbot reviewed Feb 6, 2024
View reviewed changes
.remarkrc.mjs Outdated Show resolved Hide resolved
restyled-commits and others added 19 commits February 6, 2024 06:07
@restyled-commits @DerekNonGeneric
Restyled by prettier-markdown
20ee3d7 
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
@DerekNonGeneric
fix: comply w/ rule: First heading level should be 2
6483883 
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
@DerekNonGeneric
turn off 'remark-lint-no-consecutive-dashes' rule
fa8a1ce
@DerekNonGeneric
fix: uncomment rules being enabled for unified
575999d 
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
@DerekNonGeneric
fix: unresolved deps & exceeded qty
d58ec77
@DerekNonGeneric
fix: rm slocs of rm'd deps & attempt satisying import sort
0ac0149 
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
@DerekNonGeneric
fix: 3p plugins were missing square brackets, etc.
5a80f13 
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
@DerekNonGeneric
fix: rm link checking for now
7cc4cf3 
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
@DerekNonGeneric
fix: enclose some plugins in square brackets for now
46992be 
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
@DerekNonGeneric
fix: syntax errors/styling
1ed34d5
@DerekNonGeneric
fix: syntax errors/styling
f595dbc
@OpenINFbot @DerekNonGeneric
Update .remarkrc.mjs
7d3e4b4 
Signed-off-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
@OpenINFbot @DerekNonGeneric
Update doc/collections/_adrs/0004--decision_for_tools_dir.md
b070b89 
Signed-off-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
@OpenINFbot @DerekNonGeneric
Update doc/collections/_adrs/0004--decision_for_tools_dir.md
e2e5682 
Signed-off-by: OpenINF Bot <132791922+openinfbot@users.noreply.github.com>
@restyled-commits @DerekNonGeneric
Restyled by prettier-markdown
79b99a3
@DerekNonGeneric
doc(layout): 'dist' -> 'distrib'
9bb9b23
@DerekNonGeneric
doc(adrs): 0003/next steps replaced w/ prereqs to previous procedure
8c8f0e7 
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
@restyled-commits @DerekNonGeneric
Restyled by prettier-markdown
61ff1bc
@DerekNonGeneric
Update .remarkrc.mjs
a0bea6e 
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Feb 6, 2024 •
edited
Loading

there is a shortcoming of jekyll that we are trying to avoid by not using the file extension of .jekyll; rich diffs are not available for that format on the github web UI — that's not such a huge deal especially if we have netlify deploy previews; idk, up to y'all

DerekNonGeneric
DerekNonGeneric commented Feb 6, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
@DerekNonGeneric
Update .vscode/settings.json
9acbdb2 
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
DerekNonGeneric
DerekNonGeneric commented Feb 6, 2024
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
@DerekNonGeneric
Update .vscode/settings.json
87ce74b 
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
@DerekNonGeneric
Update .vscode/settings.json
352c95d 
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
@OpenINFbot OpenINFbot merged commit cfd35cf into OpenINF:main Feb 6, 2024
5 checks passed
@DerekNonGeneric DerekNonGeneric deleted the fix/adr-file-exts branch February 6, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenINFbot OpenINFbot OpenINFbot approved these changes

Assignees

@DerekNonGeneric DerekNonGeneric

@OpenINFbot OpenINFbot

Labels
author-ready PRs that are considered ready by their author content Related to creating / editing content discuss Issues opened for discussions and feedbacks documentation Improvements or additions to documentation fast-track PRs that do not need to wait for 48 hours to land infrastructure linting Issues and PRs that deal with linting markdown An issue or PR related to Markdown 🌘 P3: Low undefined question Further information is requested testing tools Issues and PRs related to the tools directory 🔧 Type: Maintenance undefined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DerekNonGeneric @OpenINFbot @restyled-commits