Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First attempt at reorganising variables into different MIP tables. #4

Conversation

matthew-mizielinski
Copy link
Collaborator

Attempt at addressing #3

"variable_name": "flashrate"
}
},
"standard_name": "frequency_of_lightning_flashes_per_unit_area",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to add a CF link, it seems this is listed on the http://cfconventions.org/Data/cf-standard-names/79/build/cf-standard-name-table.html - don't know if there is a json/github version of this to link to (the XML doesn't provide the same functionality as a github JSON - http://cfconventions.org/Data/cf-standard-names/79/src/cf-standard-name-table.xml)? Also validating the units, in CF it lists "Canonical Units = m-2 s-1" whereas this is "km-2 s-1"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case that (some obs4MIPs, and input4MIPs variables) there is no CF standard name, this would then be obvious, and would then lead to folks being able to get stuff done immediately, with a clean up job of getting that CF standard name registered (and entered)

@matthew-mizielinski matthew-mizielinski marked this pull request as ready for review October 4, 2022 16:18
@matthew-mizielinski matthew-mizielinski merged commit a620cb6 into main Oct 4, 2022
@matthew-mizielinski matthew-mizielinski deleted the issue3_matthew-mizielinski_prototype-mip-tables-exploration branch October 4, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants