feat: Replace hand-written specs with autogenerated specs #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklimonda-cl
force-pushed
the
feat-generated-specs
branch
from
767a5f4
to
68d9245
Compare
kklimonda-cl
changed the title
kklimonda-cl
force-pushed
the
feat-generated-specs
branch
6 times, most recently
from
17913dd
to
dbdac87
Compare
Hand-written specs don't set resource_type for config resources (e.g. ntp settings, dns settings) and codegen implicitly treated them as entry-type resources without entry name. XML->YAML spec generator is always setting a correct resource_type, so it has to be handled properly.
kklimonda-cl
force-pushed
the
feat-generated-specs
branch
from
dbdac87
to
9fc5ae4
Compare
kklimonda-cl
force-pushed
the
feat-generated-specs
branch
from
9fc5ae4
to
35d0ccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import YAML specs generated directly from XML and improve codegen codebase to fix some edge cases.