-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace hand-written specs with autogenerated specs #186
Draft
kklimonda-cl
wants to merge
8
commits into
main
Choose a base branch
from
feat-generated-specs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for abc8f86 - Browse repository at this point
Copy the full SHA abc8f86View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 070a6de - Browse repository at this point
Copy the full SHA 070a6deView commit details -
Fix codegen for explicit resource_type: config
Hand-written specs don't set resource_type for config resources (e.g. ntp settings, dns settings) and codegen implicitly treated them as entry-type resources without entry name. XML->YAML spec generator is always setting a correct resource_type, so it has to be handled properly.
Configuration menu - View commit details
-
Copy full SHA for 8369ff3 - Browse repository at this point
Copy the full SHA 8369ff3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 63489cd - Browse repository at this point
Copy the full SHA 63489cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cfdbf8 - Browse repository at this point
Copy the full SHA 7cfdbf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f3911c - Browse repository at this point
Copy the full SHA 3f3911cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2822e9a - Browse repository at this point
Copy the full SHA 2822e9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35d0ccb - Browse repository at this point
Copy the full SHA 35d0ccbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.