Test new cookie with value

PhpGt · Jan 16, 2018 · 66547ea · 66547ea
1 parent 88f7fb7
commit 66547ea
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/src/Cookie.php b/src/Cookie.php
@@ -7,10 +7,10 @@ class Cookie {
 
 	public function __construct(string $name, string $value = "") {
 		if(!Validity::isValidName($name)) {
-			throw new InvalidCharactersException($name);
+			throw new InvalidCharactersException("Name contains invalid characters: $name");
 		}
 		if(!Validity::isValidValue($value)) {
-			throw new InvalidCharactersException($value);
+			throw new InvalidCharactersException("Value contains invalid characters: $value");
 		}
 
 		$this->name = $name;

diff --git a/src/Validity.php b/src/Validity.php
@@ -48,7 +48,7 @@ public static function isValidValue(string $value):bool {
 		}
 
 		$nameChars = str_split($value, 1);
-		$validChars = self::getValidNameCharacters();
+		$validChars = self::getValidValueCharacters();
 		foreach($nameChars as $c) {
 			if(!in_array($c, $validChars)) {
 				$valid = false;

diff --git a/test/unit/CookieTest.php b/test/unit/CookieTest.php
@@ -54,6 +54,19 @@ public function testSetInvalidValue(string $name, string $value) {
 		$cookie->withValue($value);
 	}
 
+	/**
+	 * @dataProvider dataNameValue
+	 */
+	public function testWithValue(string $name, string $value) {
+		$cookie = new Cookie($name, $value);
+		$value = $cookie->getValue();
+
+		$eulav = strrev($value);
+		$eikooc = new Cookie($name, $eulav);
+		self::assertNotSame($eikooc, $cookie);
+		self::assertNotEquals($value, $eikooc->getValue());
+	}
+
 	public static function dataNameValue():array {
 		$data = [];