Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built in cryptography pkcs7 signature. #113

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

salticus
Copy link

Summary

Updates cryptography to 39.0.2. Removes legacy C interface code.

Checklist

  • Classes, Variables, function and methods logic ok

@salticus salticus force-pushed the dependabot/pip/cryptography-39.0.1 branch 2 times, most recently from 086f1ae to d4f7a71 Compare April 25, 2023 00:14
Signed-off-by: Robert Stewart <rbstewart@protonmail.com>
@salticus salticus force-pushed the dependabot/pip/cryptography-39.0.1 branch from d4f7a71 to 0a5992b Compare April 25, 2023 00:22
HanslettTheDev added a commit to HanslettTheDev/pyafipws that referenced this pull request May 10, 2023
This was referenced May 10, 2023
HanslettTheDev added a commit to HanslettTheDev/pyafipws that referenced this pull request Jun 10, 2023
… the clone of the pycon commit

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
HanslettTheDev added a commit to HanslettTheDev/pyafipws that referenced this pull request Jun 17, 2023
… the clone of the pycon commit

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

fix: changed version number

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

fix(tests): fixed 4 broken tests and still one pending

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

fix: broken cryptography tests ressolved

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

fix: fixes the tests for python 2.7

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

still ressolving python2.7 build error

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

still ressolving python2.7 build error part2

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

still ressolving python2.7 build error part3

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

fix: removed accidentally pushed conf files

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

fix: changed the requirements.txt file to show version number

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

fix: changed the requirements.txt file to show version number

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

bump: crytography downgrade to 3.4.7

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

bump: crytography downgrade to 3.4.7

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

bump: crytography upgrade 3.4.7 -> 39.0.2

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

feat: backward compatible code for python 2.7 to sign transactions

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

feat: backward compatible code for python 2.7 to sign transactions

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

Testing support for python2.7

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

modified the make file to add new test commands

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

Update wsaa.py

Co-authored-by: Nico Sandoval <49107024+NicolasSandoval@users.noreply.github.com>
Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>

feat: Backward compatible code to sign certificates for python 2.7 and python 3+
HanslettTheDev added a commit to HanslettTheDev/pyafipws that referenced this pull request Jun 21, 2023
…gning method

Signed-off-by: HanslettTheDev <HanslettTheDev@gmail.com>
AFIP government webservice error:
```
pysimplesoap.client.SoapFault: ns1:cms.sign.invalid: Firma inválida o algoritmo no soportado
```

Signed-off-by: Mariano Reingart <reingart@gmail.com>
@reingart reingart force-pushed the dependabot/pip/cryptography-39.0.1 branch from 161a379 to 57126c5 Compare July 5, 2023 02:00
@reingart reingart merged commit 840f3f2 into PyAr:main Jul 5, 2023
@reingart
Copy link
Member

reingart commented Jul 5, 2023

Thanks @salticus for this great contribution in PyCon US 2023 sprints!
And thanks @HanslettTheDev for the revision and testing.
This fixes the dependabot bump ticket reingart#103

@salticus
Copy link
Author

You're welcome! Certainly most of the credit goes to @HanslettTheDev, who has done most of the difficult work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants