Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

feat(ecosystem): tier filters and new header #3443

Merged
merged 32 commits into from
Aug 1, 2023
Merged

feat(ecosystem): tier filters and new header #3443

merged 32 commits into from
Aug 1, 2023

Conversation

techtolentino
Copy link
Contributor

@techtolentino techtolentino commented Jul 20, 2023 •
edited
Loading

Changes

Closes #3404

Implementation details

  • remove tier Tabs
  • remove results logic
  • add Tier filters and filter logic
  • update page header with Tier explanation cards

Preview link

https://qiskit-org-pr-3443.dcq4xc5i083.us-south.codeengine.appdomain.cloud/ecosystem

How to read this PR

  • please review code updates and deletions in ecosystem.vue
  • need feedback on how to DRY tier and category filters / functionality
  • review the updated page header and pictogram selection

@techtolentino techtolentino marked this pull request as ready for review July 20, 2023 19:43
@y4izus y4izus force-pushed the feat/ecosystem-update-filters-and-page-header branch from 88f2146 to cc7450b Compare July 21, 2023 10:51
y4izus
y4izus suggested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@y4izus y4izus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start!! Let's continue improving it 💪 . Apart of my comments on the code, I have another one: do you think the names of the icon files could be improved?

components/Ecosystem/EcosystemJoin.vue Outdated Show resolved Hide resolved
pages/ecosystem.vue Show resolved Hide resolved
pages/ecosystem.vue Show resolved Hide resolved
@y4izus y4izus added the ON HOLD Holding. 10-yard penalty. label Jul 24, 2023
@y4izus
Copy link
Contributor

y4izus commented Jul 24, 2023

I'm adding the on-hold label because we need the input from @javabster

eddybrando
eddybrando previously approved these changes Jul 31, 2023
View reviewed changes
eddybrando
eddybrando previously approved these changes Jul 31, 2023
View reviewed changes
@techtolentino
feat(ecosystem): update copy
b2adfb1
@techtolentino
Merge branch 'feat/ecosystem-update-filters-and-page-header' of githu…
ca4e00e 
…b.com:Qiskit/qiskit.org into feat/ecosystem-update-filters-and-page-header
This was referenced Jul 31, 2023
Closed
Closed
@y4izus y4izus merged commit 94a1419 into main Aug 1, 2023
5 checks passed
@y4izus y4izus deleted the feat/ecosystem-update-filters-and-page-header branch August 1, 2023 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@y4izus y4izus y4izus approved these changes

@eddybrando eddybrando eddybrando left review comments

@javabster javabster Awaiting requested review from javabster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ecosystem] rethink how we display tiers?
3 participants
@techtolentino @y4izus @eddybrando