Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins detection and displaying #294

Closed
wants to merge 24 commits into from
Closed

Plugins detection and displaying #294

wants to merge 24 commits into from

Conversation

catornot
Copy link
Contributor

@catornot catornot commented Apr 28, 2023 •
edited by GeckoEidechse
Loading

waiting for #267

this adds plugins to the local mods area and doesn't support disabling and deleting of plugins lol

image

Closes #291

@catornot catornot changed the title Plugins detection and disaplying Plugins detection and displaying Apr 28, 2023
GeckoEidechse
GeckoEidechse requested changes Apr 30, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick test and it didn't detect the plugin. Is it still checking for only the author and mod part of the folder name? ^^"

@catornot
Copy link
Contributor Author

sounds like a skill issue
image

@GeckoEidechse
Copy link
Member

sounds like a skill issue

Ooooh I was still checking in the ThunderstoreModsView xD

At least it didn't detect it as installed there :P

@GeckoEidechse GeckoEidechse mentioned this pull request May 9, 2023
Closed
@catornot
Copy link
Contributor Author

same here

@catornot catornot closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect installed plugins
2 participants
@catornot @GeckoEidechse