Bind dmabuf v5 #441
Merged
Bind dmabuf v5 #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes creating a dmabuf with different modifiers for different planes a protocol error. This *could* be considered a breaking API change, but I don't think we need a semver bump for it because: * Callers should never have actually used different modifiers for different planes, since this was never valid. * Most users of this protocol tend to use `create_immed`, in which case they would get a protocol error. So it's "breaking" if an application calls `create` with non-sense params and then expects to get `failed`. When we do have an API break, the API should probably be changed to only allow a single modifier. This change isn't important, but will be needed for future updates to dmabuf.
wash2
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes creating a dmabuf with different modifiers for different planes a protocol error.
This could be considered a breaking API change, but I don't think we need a semver bump for it because:
create_immed, in which case they would get a protocol error. So it's "breaking" only if an application callscreatewith non-sense params and then expects to getfailed.When we do have an API break, the API should probably be changed to only allow a single modifier.
This change isn't important, but will be needed for future updates to dmabuf.