Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 0.31.0 release with crc service #3067

Merged
merged 34 commits into from
Jul 10, 2023
Merged

chore: 0.31.0 release with crc service #3067

merged 34 commits into from
Jul 10, 2023

Conversation

olevski
Copy link
Member

@olevski olevski commented May 10, 2023 •
edited
Loading

@olevski olevski requested a review from a team as a code owner May 10, 2023 21:29
@olevski olevski marked this pull request as draft May 10, 2023 21:30
@olevski olevski temporarily deployed to ci-renku-3067 May 10, 2023 21:58 — with GitHub Actions Inactive
@RenkuBot
Copy link
Collaborator

You can access the deployment of this PR at https://ci-renku-3067.dev.renku.ch

@olevski olevski temporarily deployed to ci-renku-3067 May 10, 2023 22:03 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 10, 2023 22:25 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 10, 2023 22:56 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 11, 2023 00:31 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 11, 2023 01:07 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 11, 2023 09:17 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 11, 2023 09:31 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 11, 2023 10:02 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 11, 2023 11:47 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 May 11, 2023 12:46 — with GitHub Actions Inactive
rokroskar
rokroskar reviewed Jul 7, 2023
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@bethcg
Update CHANGELOG.rst
b6fa7fd 
Detailed explanation of CRC services.
@bethcg
Update CHANGELOG.rst
9a7106d 
Improved description of this release.
rokroskar
rokroskar reviewed Jul 7, 2023
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
rokroskar
rokroskar reviewed Jul 7, 2023
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
@bethcg @rokroskar
Update CHANGELOG.rst
b0160c3 
Improved description of 0.31.0.

Co-authored-by: Rok Roškar <roskarr@ethz.ch>
@bethcg bethcg temporarily deployed to ci-renku-3067 July 8, 2023 06:55 — with GitHub Actions Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to ci-renku-3067 July 10, 2023 06:32 — with GitHub Actions Inactive
lorenzo-cavazzi
lorenzo-cavazzi previously approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested some scenarios and this works well. Very nice job! 🚀

@olevski olevski temporarily deployed to ci-renku-3067 July 10, 2023 08:59 — with GitHub Actions Inactive
bethcg
bethcg reviewed Jul 10, 2023
View reviewed changes
CHANGELOG.rst
Renku ``0.31.0`` introduces the compute resource control (CRC) service, enabling Renku administrators to manage access to
specific computing resources. The service exposes an HTTP API for the administrators to interact with. In this way,
Renku administrators can create, update or delete resource pools, and can add to or remove users from resource pools.
Please note that a user interface for the CRC has not been added yet but it will be added in a future release. Currently,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this level of detail for administrators here? It may be too long/irrelevant for regular Renku users. As for the details for the launching of sessions (next paragraph), I think it is good to provide this information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that administrators especially the ones deploying or updating to a new version of Renku are most likely to read the changelog in the repo or the docs. At least from my experience helping admins deploy Renku I have heard complaints specifically because the release notes excluded information or were too brief. Currently we have no other place to include this information as far as I know. So I think we should definitely include this here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we can make another changelog of section of the docs for this information specifically tailored for admins. But I am not sure it is worth the effort and it will only scatter information that I think belongs together.

@olevski olevski requested a review from bethcg July 10, 2023 11:04
@olevski olevski temporarily deployed to ci-renku-3067 July 10, 2023 11:06 — with GitHub Actions Inactive
bethcg
bethcg approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@bethcg bethcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

@olevski olevski temporarily deployed to ci-renku-3067 July 10, 2023 12:27 — with GitHub Actions Inactive
@olevski olevski temporarily deployed to ci-renku-3067 July 10, 2023 13:56 — with GitHub Actions Inactive
@olevski olevski deployed to ci-renku-3067 July 10, 2023 14:13 — with GitHub Actions Active
@olevski olevski merged commit c04e427 into master Jul 10, 2023
@olevski olevski deleted the crac-service-helm-chart branch July 10, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledegano aledegano aledegano approved these changes

@lorenzo-cavazzi lorenzo-cavazzi lorenzo-cavazzi approved these changes

@bethcg bethcg bethcg approved these changes

@seanrmurphy seanrmurphy Awaiting requested review from seanrmurphy

@rokroskar rokroskar Awaiting requested review from rokroskar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@olevski @RenkuBot @seanrmurphy @rokroskar @aledegano @lorenzo-cavazzi @bethcg @leafty