-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 0.31.0 release with crc service #3067
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
a7c8aad
feat: add crac service helm chart
olevski 2ea6288
squashme: minor fixes
olevski 007a60d
Merge branch 'master' into crac-service-helm-chart
leafty ba78f94
chore: add rbac for crac service
olevski d362182
Merge branch 'master' into crac-service-helm-chart
olevski 90dbcf3
squashme: set the crac service name
olevski b88a8af
Merge branch 'master' into crac-service-helm-chart
olevski 45b03c0
chore: rename crac to crc
olevski 3b940c3
chore: renam crac to crc
olevski 620c1cc
Merge branch 'master' into crac-service-helm-chart
olevski b1a46b5
Merge branch 'master' into crac-service-helm-chart
olevski b7aca52
Merge branch 'master' into crac-service-helm-chart
leafty 24d6cf4
Merge branch 'master' into crac-service-helm-chart
olevski b8b9d7f
Fix cypress-tests/cypress/e2e/publicProject.cy.ts
leafty 7b203e3
Merge branch 'master' into crac-service-helm-chart
rokroskar 7fe483d
Merge branch 'master' into crac-service-helm-chart
olevski 2b248c3
Merge branch 'master' into crac-service-helm-chart
olevski ad096bd
chore: use crc 0.0.1
olevski 4abb63a
Merge branch 'master' into crac-service-helm-chart
lorenzo-cavazzi a190aad
Merge branch 'master' into crac-service-helm-chart
leafty 716a3be
chore: update keycloak python client
olevski f15006c
squashme: correctly create postgres db
olevski 99b632e
chore: update renku notebooks to 1.16.0
olevski 1800b08
Merge branch 'master' into crac-service-helm-chart
olevski 0531367
chore: update changelog
olevski ac1ef6a
Merge branch 'master' into crac-service-helm-chart
olevski 6611309
Merge branch 'master' into crac-service-helm-chart
olevski 3912363
Merge branch 'master' into crac-service-helm-chart
olevski 439dd1f
chore: update renku-ui
olevski b6fa7fd
Update CHANGELOG.rst
bethcg 9a7106d
Update CHANGELOG.rst
bethcg b0160c3
Update CHANGELOG.rst
bethcg af464e5
Merge branch 'master' into crac-service-helm-chart
lorenzo-cavazzi e6c045a
chorre: expand changelog
olevski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{{- if and .Values.notebooks.serverOptions .Values.notebooks.serverDefaults -}} | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: {{ template "renku.fullname" . }}-server-options | ||
labels: | ||
app: {{ template "renku.name" . }} | ||
chart: {{ template "renku.chart" . }} | ||
release: {{ .Release.Name }} | ||
heritage: {{ .Release.Service }} | ||
data: | ||
server_options.json: | | ||
{{ .Values.notebooks.serverOptions | default dict | toJson }} | ||
server_defaults.json: | | ||
{{ toJson .Values.notebooks.serverDefaults }} | ||
{{- end -}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
apiVersion: apps/v1 | ||
kind: Deployment | ||
metadata: | ||
name: {{ template "renku.fullname" . }}-crc | ||
labels: | ||
app: renku-crc | ||
chart: {{ template "renku.chart" . }} | ||
release: {{ .Release.Name }} | ||
heritage: {{ .Release.Service }} | ||
spec: | ||
{{- if not .Values.crc.autoscaling.enabled }} | ||
replicas: {{ .Values.crc.replicaCount }} | ||
{{- end }} | ||
strategy: | ||
{{- toYaml .Values.crc.updateStrategy | nindent 4 }} | ||
selector: | ||
matchLabels: | ||
app: renku-crc | ||
release: {{ .Release.Name }} | ||
template: | ||
metadata: | ||
labels: | ||
app: renku-crc | ||
release: {{ .Release.Name }} | ||
{{- with .Values.crc.podAnnotations }} | ||
annotations: | ||
{{- toYaml . | nindent 8 }} | ||
{{- end }} | ||
spec: | ||
securityContext: | ||
{{- toYaml .Values.podSecurityContext | nindent 8 }} | ||
automountServiceAccountToken: {{ .Values.global.debug }} | ||
initContainers: | ||
{{- include "certificates.initContainer" . | nindent 8 }} | ||
containers: | ||
- name: crc | ||
image: "{{ .Values.crc.image.repository }}:{{ .Values.crc.image.tag }}" | ||
imagePullPolicy: {{ .Values.crc.image.pullPolicy }} | ||
securityContext: | ||
{{- toYaml .Values.securityContext | nindent 12 }} | ||
ports: | ||
- name: http | ||
containerPort: 8000 | ||
protocol: TCP | ||
env: | ||
- name: DB_HOST | ||
value: {{ template "postgresql.fullname" . }} | ||
- name: DB_USER | ||
value: {{ .Values.global.db.common.username }} | ||
- name: DB_PASSWORD | ||
valueFrom: | ||
secretKeyRef: | ||
name: {{ .Values.global.db.common.passwordSecretName }} | ||
key: password | ||
- name: KEYCLOAK_URL | ||
value: {{ (printf "%s://%s/auth/" (include "gateway.protocol" .) .Values.global.renku.domain) | quote}} | ||
- name: KEYCLOAK_TOKEN_SIGNATURE_ALGS | ||
value: "RS256" | ||
- name: SERVER_DEFAULTS | ||
value: /etc/renku-crc/server_options/server_defaults.json | ||
- name: SERVER_OPTIONS | ||
value: /etc/renku-crc/server_options/server_options.json | ||
- name: K8S_NAMESPACE | ||
value: {{ .Release.Namespace | quote }} | ||
volumeMounts: | ||
- name: server-options | ||
mountPath: /etc/renku-crc/server_options | ||
{{- include "certificates.volumeMounts.system" . | nindent 12 }} | ||
livenessProbe: | ||
httpGet: | ||
path: /api/data/version | ||
port: http | ||
initialDelaySeconds: 10 | ||
periodSeconds: 10 | ||
failureThreshold: 6 | ||
readinessProbe: | ||
httpGet: | ||
path: /api/data/version | ||
port: http | ||
initialDelaySeconds: 10 | ||
periodSeconds: 2 | ||
failureThreshold: 2 | ||
startupProbe: | ||
httpGet: | ||
path: /api/data/version | ||
port: http | ||
periodSeconds: 5 | ||
failureThreshold: 60 | ||
resources: | ||
{{ toYaml .Values.crc.resources | nindent 12 }} | ||
{{- with .Values.crc.nodeSelector }} | ||
nodeSelector: | ||
{{ toYaml . | nindent 8 }} | ||
{{- end }} | ||
{{- with .Values.crc.affinity }} | ||
affinity: | ||
{{ toYaml . | nindent 8 }} | ||
{{- end }} | ||
{{- with .Values.crc.tolerations }} | ||
tolerations: | ||
{{ toYaml . | nindent 8 }} | ||
{{- end }} | ||
volumes: | ||
- name: server-options | ||
configMap: | ||
name: {{ template "renku.fullname" . }}-server-options | ||
{{- include "certificates.volumes" . | nindent 8 }} | ||
serviceAccountName: {{ template "renku.fullname" . }}-crc |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep this level of detail for administrators here? It may be too long/irrelevant for regular Renku users. As for the details for the launching of sessions (next paragraph), I think it is good to provide this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that administrators especially the ones deploying or updating to a new version of Renku are most likely to read the changelog in the repo or the docs. At least from my experience helping admins deploy Renku I have heard complaints specifically because the release notes excluded information or were too brief. Currently we have no other place to include this information as far as I know. So I think we should definitely include this here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively we can make another changelog of section of the docs for this information specifically tailored for admins. But I am not sure it is worth the effort and it will only scatter information that I think belongs together.