Add XMLRPC services to manage ITS #210
Conversation
Create, Update, Link with a test project
Manage this branch in SquashTest this branch here: https://atisnefeature-api-manage-its-su5sw.squash.io |
locale/en_GB/strings.txt
Outdated
| @@ -3162,6 +3162,7 @@ $TLS_API_NO_TESTSUITEID = "No testsuiteid provided."; | |||
| $TLS_API_NO_TPID = "No testplan ID (testplanid) provided."; | |||
| $TLS_API_NO_TCID = "No testcase ID (testcaseid) provided."; | |||
| $TLS_API_NO_PLATFORMID = "No Platform ID (platformid) provided."; | |||
| $TLS_API_NO_ITSID = "NO ITS ID (itsid) provided."; | |||
There was a problem hiding this comment.
Please provide a better message => NO Issue Tracker Sistem ID ....
lib/api/xmlrpc/v1/xmlrpc.class.php
Outdated
| @@ -216,6 +216,10 @@ class TestlinkXMLRPCServer extends IXR_Server { | |||
| public static $testCaseVersionParamName = "tcversion"; | |||
| public static $itsNameParamName = "itsname"; | |||
| public static $itsEnabledParamName = "itsenabled"; | |||
| public static $itsTypeParamName = "itstype"; | |||
There was a problem hiding this comment.
Do not think an specific name is needed => parameter can be named only 'type'
same per enabled, same per cfg, probably same for id
There was a problem hiding this comment.
I changed some. But I'm really not sure we can always safely use attribute names without typed them. Especially some that may be used in the same time with others concepts. It may results conflicts.
There was a problem hiding this comment.
I know that in the past this approach has been the rule, but IMHO in some moments is an overkill.
Then I prefer to think about a solution if the situation will happens
regards
There was a problem hiding this comment.
If the situation happens, you will must broke the API. It's a big impact, isn't it?
There was a problem hiding this comment.
This is not going to happen if people pay attention to what is doing, testing
There was a problem hiding this comment.
I'm not sure to well understand.
Imagine I want to add a service to link a test project to an ITS. This service will take as input a test project ID and an ITS ID. Both parameters cannot have the same name ('id'). These names are used as array keys. So we must name them differently ('testprojectid' and 'itsid').
If we rename later a parameter to avoid this kind of conflict, we will break the API and will impact existing code that use it.
That's why I think it's better to distinguish parameter names without presuming the future.
If parameter names have the same names, we cannot use them together. And if we change them later, we will break existing stuff.
There was a problem hiding this comment.
nodoby have said that testprojectid parameter name has to be changed to id, but that itsid can be changed to id.
Then my choice is wait for requested changet to accept the code.
In addition:
- sample php clients to test implementation are a good things to do
- create the method to remove link between test project and issue tracking system is IMHO needed. I've not fully read the code maybe implementation has been done passing 0 as ITS id using the set method
There was a problem hiding this comment.
nodoby have said that testprojectid parameter name has to be changed to id, but that itsid can be changed to id.
Sure. But I think it's not a good idea to not have a global rule. In which cases I can or I cannot?...
Then my choice is wait for requested changet to accept the code.
I don't understand what do you mean here.
In addition:
* sample php clients to test implementation are a good things to do
Do you have guidelines to do this?
* create the method to remove link between test project and issue tracking system is IMHO needed. I've not fully read the code maybe implementation has been done passing 0 as ITS id using the set method
You're right. I will try to add it.
atisne
force-pushed
the
feature-API_manage_ITS
branch
from
5083980
to
131f26d
Compare
atisne
force-pushed
the
feature-API_manage_ITS
branch
from
131f26d
to
32fd1ff
Compare
atisne
force-pushed
the
feature-API_manage_ITS
branch
from
32fd1ff
to
be39e0f
Compare
|
Hi Francisco, I've amended the request as you suggested. Could you please reconsider it? |
Create, Update, Link an ITS with a test project via XMLRPC API
Useful to easily interface Testlink from external bug trackers (plugins)