etc: update klayout version #2579
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Klayout org only provides the latest versions for new OSes such as RHEL9/RockyLinux9/Ubuntu24 Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
rovinski
reviewed
Nov 22, 2024
etc/DependencyInstaller.sh
Outdated
| else | ||
| klayoutChecksum=db751264399706a23d20455bb7624264 | ||
| echo "Could not find checksum for klayout" |
There was a problem hiding this comment.
A more actionable message would be better for the user
Suggested change
| echo "Could not find checksum for klayout" | |
| echo "KLayout does not provide binaries for detected Ubuntu version $1. Please install KLayout manually." |
There was a problem hiding this comment.
I could imagine a case where 26.04 comes out and we haven't updated yet. klayout might provide binaries and our script is just behind. Perhaps "Unrecognized version of Ubuntu $1. Please install KLayout manually".
@vvbandeira this has been lingering a while.
There was a problem hiding this comment.
The CI failed with the update, and I did not have the time to take a closer look at the error. I will try to get back later this week.
vvbandeira
commented
Dec 17, 2024
Signed-off-by: Vitor Bandeira <vvbandeira@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Klayout org only provides the latest versions for new OSes such as RHEL9/RockyLinux9/Ubuntu24