Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etc: update klayout version #2579

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

etc: update klayout version #2579

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4d7176
etc: update klayout version
Nov 21, 2024
94a887d
Update etc/DependencyInstaller.sh
vvbandeira Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions etc/DependencyInstaller.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ else
fi

# package versions
klayoutVersion=0.28.8
klayoutVersion=0.29.8
verilatorVersion=5.026

_versionCompare() {
Expand Down Expand Up @@ -158,9 +158,14 @@ _installUbuntuPackages() {
fi
else
if [[ $1 == 20.04 ]]; then
klayoutChecksum=15a26f74cf396d8a10b7985ed70ab135
klayoutChecksum=bfa011330bc9e1f61b46f668379cc741
elif [[ $1 == 22.04 ]]; then
klayoutChecksum=60839f6b5b2b1c1e76bf0c1bc17bf18c
elif [[ $1 == 24.04 ]]; then
klayoutChecksum=b8909538985b15135b49e8d32a089d72
else
klayoutChecksum=db751264399706a23d20455bb7624264
echo "Could not find checksum for klayout"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more actionable message would be better for the user

Suggested change
echo "Could not find checksum for klayout"
echo "KLayout does not provide binaries for detected Ubuntu version $1. Please install KLayout manually."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could imagine a case where 26.04 comes out and we haven't updated yet. klayout might provide binaries and our script is just behind. Perhaps "Unrecognized version of Ubuntu $1. Please install KLayout manually".

@vvbandeira this has been lingering a while.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failed with the update, and I did not have the time to take a closer look at the error. I will try to get back later this week.

vvbandeira marked this conversation as resolved.
Show resolved Hide resolved
exit 1
fi
wget https://www.klayout.org/downloads/Ubuntu-${1%.*}/klayout_${klayoutVersion}-1_amd64.deb
md5sum -c <(echo "${klayoutChecksum} klayout_${klayoutVersion}-1_amd64.deb") || exit 1
Expand Down
Loading