Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: player prefab spawning not honoring when spawnwithobservers is disabled #3077

Merged
merged 4 commits into from
Sep 27, 2024
Merged

fix: player prefab spawning not honoring when spawnwithobservers is disabled #3077

merged 4 commits into from
Sep 27, 2024

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Sep 26, 2024 •
edited
Loading

Regression Bug
During the distributed authority updates a regression bug occurred where NetworkObject.SpawnWithObservers was no longer being honored in both client-server and distributed authority network topologies when spawning player prefabs.

MTTB-479

fix: #3076

Changelog

  • Fixed: Issue where NetworkObject.SpawnWithObservers was not being honored when spawning the player prefab.

Testing and Documentation

  • Includes integration test PlayerSpawnNoObserversTest.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
e617308 
When SpawnWithObservers is disabled on player prefab, the instantiated instance should only spawn on the authority side.
For client-server this will always be the server/host.
For distributed authority this will always be the owner.
@NoelStephensUnity
test
25b827e 
Validation test for the SpawnWithObservers regression bug.
@NoelStephensUnity
update
2806ee0 
updating changelog entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review September 26, 2024 22:25
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner September 26, 2024 22:25
@NoelStephensUnity NoelStephensUnity merged commit cb7ec98 into develop-2.0.0 Sep 27, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/player-prefab-not-honoring-spawn-with-observers branch September 27, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlucas-unity samlucas-unity samlucas-unity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NoelStephensUnity @samlucas-unity