Pull request to merge #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was observed to lead to a SIGILL error. It could be due to num_inliers being zero, or that inlier_ration ^ kMinNumSamples being so small, that it flushes to zero.
* Keep precision in the process of storing in text. * Remove std::fix and use the full 17 digits precision for all double varaibles.
* Expose CameraMode and UpdateImageReaderOptionsFromCameraMode * Expose the internals of RunPointTriangulator
…he fundamental matrix in EstimateUncalibrated function. (#1369)
* Remove deprecated Mac OSX 10.14 image in ADO pipeline * Add MacOS 11 build job
* Fix clang compiler warnings * Fix
* Add Address Sanitizer options and fix reported issues * Add CI build * Fix * Asan with clang
* Add Address Sanitizer options and fix reported issues * Add CI build * Fix * Asan with clang * Small cosmetic fixes to recent ASan support
* Add ADO pipeline for Visual Studio 2022 * Revert vcpkg
* Adding GPS conversions to and from ENU coords. (GPS -> ENU, ECEF -> ENU, ENU -> GPS, ENU -> ECEF). * Update of ModelAligner function. Now handles either GPS or custom coordinates as reference coordinates for alignment. Alignment to pure ENU frame offered as an option. Aligning reconstruction to ref coords. origin offered as an option. Fix the alignment to plane case if no ref or database provided. Documentation added for the function. * Adding const & const ref. * Removing begining / trailing spaces. * Ensure that first image exists when using merge_origins option. * Using Eigen isApprox function in the BOOST_CHECK functions instead of per vector elements checks. * Explicitly give the ref/origin lat/lon coordinates when converting from Ell to ENU. * Add a ConvertCameraLocations function to apply the common conversion of the ReadFileCameraLocations and ReadDatabaseCameraLocations functions. * Directly iterate over the containers in the range-based for loops in the ReadDatabaseCameraLocations & ReadFileCameraLocations functions. * Adding a const and turning output function parameters to pointers.
…XIF orientation flag into account when reading images. (#1406) Co-authored-by: Maxime Ferrera <maxime.ferrera@ifremer.fr>
#1408) * Adding user-specified option for reconstructing purely planar scene. If option is set, estimation of homography-based two-view geometry for matching will be forced. * Changed pure_planar_scene for planar_scene. Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
* Replace Graclus with Metis dependency * Update pipelines
Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
* Speedup for vote and verify * f * tests
* Option manager moves to controllers to disentangle circular deps * Granular CMake module targets * d * d * d * d * d * d * d * d * d * d * f * f * remove cycles * d * d * Finished removing all cycles * f * One more * f * openmp * d * d * f * f * d * d * f * d * f * d * d * f * d * d * d * d
* f * d * d * t * d * d * d
Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
* lib folder becomes thirdparty folder * f
* Introduce abstract feature extractor * d * t * Avoid unnecessary data copies in feature conversion utils
* Abstract feature matcher * d * d * d * d * lock * d
Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
* Encapsulate feature matching controller/worker implementations * Encapsulate feature extraction controllers/workers
* Reenable VS2022 CI pipeline * vcpkg upgrade * Attempt to fix * n * n * n * n * d
…lutePose function (#2089) * Add ReprojErrorConstantPoint3DCostFunction to speed up the RefineAbsolutePose function * Remove useless points3D_copy * Rename variable * Remove explicit * Remove lines * Add a unit test for this new cost function
Conditionally add the files `testing.h` and `testing.cc` to the library target `colmap_util` only if `TESTS_ENABLED=ON`. Otherwise one needs the `gtest/gtest.h` header available, for example by installing the Debian package `libgtest-dev`, even though no tests are actually built. Using the `target_sources()` function (Introduced with CMake 3.1`) to conditionally add the two testing files to the util target. https://cmake.org/cmake/help/latest/command/target_sources.html Fixes: #2101
…f set fixed (#2095) * Transform back to existing images positions after mapper process if user set existing images as fixed in RunMapper(). * Variable name modif. * Update sfm.cc * Update sfm.cc --------- Co-authored-by: Johannes Schönberger <jsch@demuc.de> Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
Vincentqyw
force-pushed
the
dev
branch
2 times, most recently
from
525a1c1
to
6bd475b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.