Fix Application deserialization with Meetings custom webhooks

Vonage · Oct 10, 2023 · 5266be5 · 5266be5
1 parent 37c429b
commit 5266be5
Show file tree

Hide file tree

Showing 4 changed files with 76 additions and 47 deletions.
diff --git a/Vonage.Test.Unit/ApplicationTests.cs b/Vonage.Test.Unit/ApplicationTests.cs
@@ -268,53 +268,7 @@ public async void DeleteApplicationAsync(bool passCreds)
         public void GetApplication(bool passCreds)
         {
             var id = "78d335fa323d01149c3dd6f0d48968cf";
-            var expectedResponse = @"{
-                  ""id"": ""78d335fa323d01149c3dd6f0d48968cf"",
-                  ""name"": ""My Application"",
-                  ""capabilities"": {
-                                ""voice"": {
-                                    ""webhooks"": {
-                                        ""answer_url"": {
-                                            ""address"": ""https://example.com/webhooks/answer"",
-                          ""http_method"": ""GET""
-                                        },
-                        ""fallback_answer_url"": {
-                                            ""address"": ""https://fallback.example.com/webhooks/answer"",
-                          ""http_method"": ""GET""
-                        },
-                        ""event_url"": {
-                                            ""address"": ""https://example.com/webhooks/event"",
-                          ""http_method"": ""POST""
-                        }
-                                    }
-                                },
-                    ""messages"": {
-                                    ""webhooks"": {
-                                        ""inbound_url"": {
-                                            ""address"": ""https://example.com/webhooks/inbound"",
-                          ""http_method"": ""POST""
-                                        },
-                        ""status_url"": {
-                                            ""address"": ""https://example.com/webhooks/status"",
-                          ""http_method"": ""POST""
-                        }
-                                    }
-                                },
-                    ""rtc"": {
-                                    ""webhooks"": {
-                                        ""event_url"": {
-                                            ""address"": ""https://example.com/webhooks/event"",
-                          ""http_method"": ""POST""
-                                        }
-                                    }
-                                },
-                    ""vbc"": { }
-                            },
-                  ""keys"": {
-                                ""public_key"": ""some public key"",
-                    ""private_key"": ""some private key""
-                  }
-                        }";
+            var expectedResponse = this.GetResponseJson();
             var expectedUri = $"{this.ApiUrl}/v2/applications/{id}";
             this.Setup(expectedUri, expectedResponse);
             var creds = Credentials.FromApiKeyAndSecret(this.ApiKey, this.ApiSecret);

diff --git a/Vonage.Test.Unit/Data/ApplicationTests/GetApplication-response.json b/Vonage.Test.Unit/Data/ApplicationTests/GetApplication-response.json
@@ -0,0 +1,63 @@
+{
+  "id": "78d335fa323d01149c3dd6f0d48968cf",
+  "name": "My Application",
+  "capabilities": {
+    "voice": {
+      "webhooks": {
+        "answer_url": {
+          "address": "https://example.com/webhooks/answer",
+          "http_method": "GET"
+        },
+        "fallback_answer_url": {
+          "address": "https://fallback.example.com/webhooks/answer",
+          "http_method": "GET"
+        },
+        "event_url": {
+          "address": "https://example.com/webhooks/event",
+          "http_method": "POST"
+        }
+      }
+    },
+    "messages": {
+      "webhooks": {
+        "inbound_url": {
+          "address": "https://example.com/webhooks/inbound",
+          "http_method": "POST"
+        },
+        "status_url": {
+          "address": "https://example.com/webhooks/status",
+          "http_method": "POST"
+        }
+      }
+    },
+    "rtc": {
+      "webhooks": {
+        "event_url": {
+          "address": "https://example.com/webhooks/event",
+          "http_method": "POST"
+        }
+      }
+    },
+    "vbc": {},
+    "meetings": {
+      "webhooks": {
+        "room_changed": {
+          "address": "http://example.com",
+          "http_method": "POST"
+        },
+        "session_changed": {
+          "address": "http://example.com",
+          "http_method": "POST"
+        },
+        "recording_changed": {
+          "address": "https://54eba990d025.ngrok.app/recordings",
+          "http_method": "POST"
+        }
+      }
+    }
+  },
+  "keys": {
+    "public_key": "some public key",
+    "private_key": "some private key"
+  }
+}
diff --git a/Vonage.Test.Unit/Vonage.Test.Unit.csproj b/Vonage.Test.Unit/Vonage.Test.Unit.csproj
@@ -862,6 +862,9 @@
         <None Update="Users\UpdateUser\Data\ShouldSerializeEmpty-request.json">
             <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
         </None>
+        <None Update="Data\ApplicationTests\GetApplication-response.json">
+          <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+        </None>
     </ItemGroup>
     <Target Name="PreBuild" BeforeTargets="PreBuildEvent">
         <Exec Command="node ../.scripts/init.js"/>

diff --git a/Vonage/Common/Webhook.cs b/Vonage/Common/Webhook.cs
@@ -32,6 +32,15 @@ public enum Type
 
         [EnumMember(Value = "Unknown")]
         Unknown = 6,
+
+        [EnumMember(Value = "room_changed")]
+        RoomChanged =7,
+
+        [EnumMember(Value = "session_changed")]
+        SessionChanged=8,
+
+        [EnumMember(Value = "recording_changed")]
+        RecordingChanged = 9,
     }
 
 }