Skip to content

Fix Application deserialization with Meetings custom webhooks

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Oct 10, 2023 in 36s

CodeScene PR Check

βœ… Quality Gates: OK

  • Declining Code Health: 0 findings(s) 🚩
  • Improving Code Health: 2 findings(s) βœ…
  • Affected Hotspots: 0 files(s) πŸ”₯

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

βœ… Positive Code Health Impact (highest to lowest):

  • Code Duplication ApplicationTests.cs: GetApplication
  • Large Method ApplicationTests.cs: GetApplication

Annotations

Check notice on line 1 in Vonage.Test.Unit/ApplicationTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… Getting better: Code Duplication

reduced similar code in: GetApplication. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check notice on line 271 in Vonage.Test.Unit/ApplicationTests.cs

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

βœ… No longer an issue: Large Method

GetApplication is no longer above the threshold for lines of code. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.