perf: Use MBF smoother by default in TrackHelpers in Examples track finding

[andiwand]

Making the MBF smoother default in the Examples track finding after #3420

[github-actions]

📊: Physics performance monitoring for abaa014

Full contents

physmon summary

• ✅ Particles fatras
• ✅ Particles geant4
• ✅ Particles ttbar
• ✅ Vertices ttbar
• ✅ Truth tracking (KF)
• ✅ Truth tracking (GSF)
• ✅ Truth tracking (GX2F)
• ✅ Truth tracking (KF refit)
• ✅ Truth tracking (GSF refit)
• 🔴 CKF finding performance | trackfinding | single muon | truth smeared seeding
• 🔴 CKF fitting performance | trackfinding | single muon | truth smeared seeding
• ✅ CKF track summary | trackfinding | single muon | truth smeared seeding
• ✅ Seeding trackfinding | single muon | truth estimated seeding
• 🔴 CKF finding performance | trackfinding | single muon | truth estimated seeding
• 🔴 CKF fitting performance | trackfinding | single muon | truth estimated seeding
• ✅ CKF track summary | trackfinding | single muon | truth estimated seeding
• ✅ Seeding trackfinding | single muon | default seeding
• 🔴 CKF finding performance | trackfinding | single muon | default seeding
• 🔴 CKF fitting performance | trackfinding | single muon | default seeding
• ✅ CKF track summary | trackfinding | single muon | default seeding
• ✅ Seeding trackfinding | single muon | orthogonal seeding
• 🔴 CKF finding performance | trackfinding | single muon | orthogonal seeding
• 🔴 CKF fitting performance | trackfinding | single muon | orthogonal seeding
• ✅ CKF track summary | trackfinding | single muon | orthogonal seeding
• ✅ Seeding trackfinding | 4 muon x 50 vertices | default seeding
• 🔴 CKF finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• 🔴 CKF fitting performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ CKF track summary | trackfinding | 4 muon x 50 vertices | default seeding
• 🔴 Ambisolver finding performance | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ IVF notime | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ AMVF gauss notime | trackfinding | 4 muon x 50 vertices | default seeding
• 🔴 AMVF grid time | trackfinding | 4 muon x 50 vertices | default seeding
• ✅ Seeding trackfinding | ttbar with 200 pileup | default seeding
• 🔴 CKF finding performance | trackfinding | ttbar with 200 pileup | default seeding
• 🔴 CKF fitting performance | trackfinding | ttbar with 200 pileup | default seeding
• 🔴 CKF track summary | trackfinding | ttbar with 200 pileup | default seeding
• 🔴 Ambisolver finding performance | trackfinding | ttbar with 200 pileup | default seeding
• 🔴 AMVF gauss notime | trackfinding | ttbar with 200 pileup | default seeding
• 🔴 AMVF grid time | trackfinding | ttbar with 200 pileup | default seeding

[paulgessinger]

Did this have a significant impact on performance?

[andiwand]

Did this have a significant impact on performance?

I measured a speedup of 2.56 which does not really effect the overall track finding performance because we only spend about 1% of the time in the smoothing step. I measured that with ODD and Fatras so it might have a bigger impact with full sim and ITk. Since we do not loose anything be using this I thought it makes sense to use it as a default.

Interestingly it seems to shift some outlier tracks which is why physmon fails. Some of the pT outliers are shuffled around but I think those where outliers in the first place.

[paulgessinger]

My only argument against this is that it's nice to have the straight up 1:1 Frühwirth smoothing as the default, since it's readily available in literature.

[andiwand]

My only argument against this is that it's nice to have the straight up 1:1 Frühwirth smoothing as the default, since it's readily available in literature.

Good point - maybe it makes more sense to use it per default in the Examples then?

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[paulgessinger]

No objections. Would we be testing / monitoring the gain matrix smoother anywhere? Might be nice to avoid decay.

[andiwand]

No objections. Would we be testing / monitoring the gain matrix smoother anywhere? Might be nice to avoid decay.

There is a unit test for the GMS https://github.com/acts-project/acts/blob/main/Tests/UnitTests/Core/TrackFitting/GainMatrixSmootherTests.cpp but I don't know if that is sufficient

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud