-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Use MBF smoother by default in TrackHelpers
in Examples track finding
#3582
base: main
Are you sure you want to change the base?
Conversation
Did this have a significant impact on performance? |
I measured a speedup of Interestingly it seems to shift some outlier tracks which is why physmon fails. Some of the pT outliers are shuffled around but I think those where outliers in the first place. |
My only argument against this is that it's nice to have the straight up 1:1 Frühwirth smoothing as the default, since it's readily available in literature. |
Good point - maybe it makes more sense to use it per default in the Examples then? |
Quality Gate passedIssues Measures |
TrackHelpers
TrackHelpers
in Examples track finding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections. Would we be testing / monitoring the gain matrix smoother anywhere? Might be nice to avoid decay.
There is a unit test for the GMS https://github.com/acts-project/acts/blob/main/Tests/UnitTests/Core/TrackFitting/GainMatrixSmootherTests.cpp but I don't know if that is sufficient |
Quality Gate passedIssues Measures |
Making the MBF smoother default in the Examples track finding after #3420