Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use MBF smoother by default in TrackHelpers in Examples track finding #3582

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Core/include/Acts/Utilities/TrackHelpers.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Result<typename track_proxy_t::ConstTrackStateProxy> findLastMeasurementState(
TrackExtrapolationError::CompatibleTrackStateNotFound);
}

/// @brief Smooth a track using the gain matrix smoother
/// @brief Smooth a track using the gain matrix smoother by default
///
/// @tparam track_proxy_t The track proxy type
/// @tparam smoother_t The smoother type
Expand All @@ -100,7 +100,7 @@ template <TrackProxyConcept track_proxy_t,
Result<void> smoothTrack(
const GeometryContext &geoContext, track_proxy_t &track,
const Logger &logger = *getDefaultLogger("TrackSmoother", Logging::INFO),
smoother_t smoother = GainMatrixSmoother()) {
smoother_t smoother = smoother_t()) {
auto &trackContainer = track.container();
auto &trackStateContainer = trackContainer.trackStateContainer();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
#include "Acts/Surfaces/Surface.hpp"
#include "Acts/TrackFinding/CombinatorialKalmanFilter.hpp"
#include "Acts/TrackFitting/GainMatrixUpdater.hpp"
#include "Acts/TrackFitting/MbfSmoother.hpp"
#include "Acts/Utilities/Enumerate.hpp"
#include "Acts/Utilities/Logger.hpp"
#include "Acts/Utilities/TrackHelpers.hpp"
Expand Down Expand Up @@ -493,8 +494,8 @@ ProcessCode TrackFindingAlgorithm::execute(const AlgorithmContext& ctx) const {
auto trackCandidate = tracksTemp.makeTrack();
trackCandidate.copyFrom(firstTrack, true);

auto firstSmoothingResult =
Acts::smoothTrack(ctx.geoContext, trackCandidate, logger());
auto firstSmoothingResult = Acts::smoothTrack(
ctx.geoContext, trackCandidate, logger(), Acts::MbfSmoother());
if (!firstSmoothingResult.ok()) {
m_nFailedSmoothing++;
ACTS_ERROR("First smoothing for seed "
Expand Down Expand Up @@ -588,7 +589,8 @@ ProcessCode TrackFindingAlgorithm::execute(const AlgorithmContext& ctx) const {
// smooth the full track and extrapolate to the reference

auto secondSmoothingResult =
Acts::smoothTrack(ctx.geoContext, trackCandidate, logger());
Acts::smoothTrack(ctx.geoContext, trackCandidate, logger(),
Acts::MbfSmoother());
if (!secondSmoothingResult.ok()) {
m_nFailedSmoothing++;
ACTS_ERROR("Second smoothing for seed "
Expand Down
Loading