[flink] Upgrade sink connector to new API version #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded sink connector from deprecated RichSinkFunction to new Sink interface - Adapted corresponding unit test cases Issue alibaba#132
2 tasks
|
LGTM, cc @wuchong. |
michaelkoepf
changed the title
michaelkoepf
commented
Dec 17, 2024
| @@ -90,14 +84,13 @@ public FlinkSinkFunction( | |||
| this.tableRowType = tableRowType; | |||
| } | |||
|
|
|||
| @Override | |||
| public void open(org.apache.flink.configuration.Configuration config) { | |||
| public void initialize(WriterInitContext context) { | |||
There was a problem hiding this comment.
Naming this function initialize instead of open is intentional to avoid ambiguities with old Flink API
- Adapted access modifiers - Consistent naming Issue alibaba#132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #132
Upgrade sink connector from deprecated RichSinkFunction (will be removed in Flink 2.0) to new Sink interface
Tests
com.alibaba.fluss.connector.flink.sink.FlinkSinkWriterTest.javacom.alibaba.fluss.connector.flink.sink.FlinkTableSinkITCase.javaAPI and Format
n/a
Documentation
n/a