-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flink] Upgrade sink connector to new API version #205
Open
michaelkoepf
wants to merge
2
commits into
alibaba:main
Choose a base branch
from
michaelkoepf:flink/connectors-upgrade-to-new-sink-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
115 changes: 115 additions & 0 deletions
115
...fluss-connector-flink/src/main/java/com/alibaba/fluss/connector/flink/sink/FlinkSink.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| /* | ||
| * Copyright (c) 2024 Alibaba Group Holding Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.alibaba.fluss.connector.flink.sink; | ||
|
|
||
| import com.alibaba.fluss.annotation.Internal; | ||
| import com.alibaba.fluss.config.Configuration; | ||
| import com.alibaba.fluss.connector.flink.sink.writer.AppendSinkWriter; | ||
| import com.alibaba.fluss.connector.flink.sink.writer.FlinkSinkWriter; | ||
| import com.alibaba.fluss.connector.flink.sink.writer.UpsertSinkWriter; | ||
| import com.alibaba.fluss.metadata.TablePath; | ||
|
|
||
| import org.apache.flink.api.connector.sink2.Sink; | ||
| import org.apache.flink.api.connector.sink2.SinkWriter; | ||
| import org.apache.flink.api.connector.sink2.WriterInitContext; | ||
| import org.apache.flink.table.data.RowData; | ||
| import org.apache.flink.table.types.logical.RowType; | ||
|
|
||
| import javax.annotation.Nullable; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.Serializable; | ||
|
|
||
| /** Flink sink for Fluss. */ | ||
| public class FlinkSink implements Sink<RowData> { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final SinkWriterBuilder<? extends FlinkSinkWriter> builder; | ||
|
|
||
| public FlinkSink(SinkWriterBuilder<? extends FlinkSinkWriter> builder) { | ||
| this.builder = builder; | ||
| } | ||
|
|
||
| @Deprecated | ||
| @Override | ||
| public SinkWriter<RowData> createWriter(InitContext context) throws IOException { | ||
| throw new UnsupportedOperationException( | ||
| "Not supported. Use FlinkSink#createWriter(WriterInitContext context)"); | ||
| } | ||
|
|
||
| @Override | ||
| public SinkWriter<RowData> createWriter(WriterInitContext context) throws IOException { | ||
| FlinkSinkWriter flinkSinkWriter = builder.createWriter(); | ||
| flinkSinkWriter.initialize(context); | ||
| return flinkSinkWriter; | ||
| } | ||
|
|
||
| @Internal | ||
| interface SinkWriterBuilder<W extends FlinkSinkWriter> extends Serializable { | ||
| W createWriter(); | ||
| } | ||
|
|
||
| @Internal | ||
| static class AppendSinkSinkWriterBuilder implements SinkWriterBuilder<AppendSinkWriter> { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final TablePath tablePath; | ||
| private final Configuration flussConfig; | ||
| private final RowType tableRowType; | ||
|
|
||
| public AppendSinkSinkWriterBuilder( | ||
| TablePath tablePath, Configuration flussConfig, RowType tableRowType) { | ||
| this.tablePath = tablePath; | ||
| this.flussConfig = flussConfig; | ||
| this.tableRowType = tableRowType; | ||
| } | ||
|
|
||
| @Override | ||
| public AppendSinkWriter createWriter() { | ||
| return new AppendSinkWriter(tablePath, flussConfig, tableRowType); | ||
| } | ||
| } | ||
|
|
||
| @Internal | ||
| static class UpsertSinkWriterBuilder implements SinkWriterBuilder<UpsertSinkWriter> { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final TablePath tablePath; | ||
| private final Configuration flussConfig; | ||
| private final RowType tableRowType; | ||
| private final @Nullable int[] targetColumnIndexes; | ||
|
|
||
| UpsertSinkWriterBuilder( | ||
| TablePath tablePath, | ||
| Configuration flussConfig, | ||
| RowType tableRowType, | ||
| @Nullable int[] targetColumnIndexes) { | ||
| this.tablePath = tablePath; | ||
| this.flussConfig = flussConfig; | ||
| this.tableRowType = tableRowType; | ||
| this.targetColumnIndexes = targetColumnIndexes; | ||
| } | ||
|
|
||
| @Override | ||
| public UpsertSinkWriter createWriter() { | ||
| return new UpsertSinkWriter(tablePath, flussConfig, tableRowType, targetColumnIndexes); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming this function
initializeinstead ofopenis intentional to avoid ambiguities with old Flink API