-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to add space between behind & ahead upstream #111
Conversation
Signed-off-by: marcoSven <me@marcosven.com>
Can't you obtain the same outcome by adding a space in front of the behind symbols in your gitmux file? |
We only want to add a space between ahead and behind count. Adding a space in front would add an undesired extra space. "Ahead""\sBehind" "\sBehind" <- undesired space |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this.
Please add 2 unit tests:
- where
divergence_space=true
andswap_divergence=false
- where
divergence_space=true
andswap_divergence=true
e588ab1
to
5902577
Compare
Signed-off-by: marcoSven <me@marcosven.com>
5902577
to
33eb0cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay between review.
There's just a last thing and we're good
Thank you.
@@ -83,3 +83,4 @@ tmux: | |||
hide_clean: false | |||
# Swaps order of behind & ahead upstream counts - "↓·1↑·1" -> "↑·1↓·1" | |||
swap_divergence: false | |||
divergence_space: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This misses a doc string. You can use the same one as the readme.
The content of this file is output for gitmux -printfg
@marcoSven I'm closing this in favor of #117 which got your code and some additional commits I've made on top of them. thank you! |
Purpose
Adding a space between behind & ahead upstream is currently not possible
Approach
Adding an option to add a single space
Before
After