Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't remove cluster with unhealthy mng #5746

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Feb 28, 2024

Fixes #N/A

Description
Skips the cluster cleanup process if the kubelet is not ready on one of the MNG nodes. This is to help diagnose the following failure: https://github.com/aws/karpenter-provider-aws/actions/runs/8032556917/job/21942085645.

How was this change tested?
/karpenter snapshot

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner February 28, 2024 17:28
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 97d5ec3
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/65e2605e84ee270009e599fb

Copy link
Contributor Author

@jmdeal jmdeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@coveralls
Copy link

coveralls commented Feb 28, 2024

Pull Request Test Coverage Report for Build 8118291183

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 82.642%

Totals Coverage Status
Change from base Build 8118173378: 0.02%
Covered Lines: 5256
Relevant Lines: 6360

💛 - Coveralls

Copy link
Contributor

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-fb352b4610e8ec1f7d558a8e7b98048a4c818c4a.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot --version "0-fb352b4610e8ec1f7d558a8e7b98048a4c818c4a" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@jmdeal jmdeal force-pushed the skip-cleanup-unhealthy-nodes branch from fb352b4 to 8d84f13 Compare March 1, 2024 22:41
@jmdeal jmdeal force-pushed the skip-cleanup-unhealthy-nodes branch from 8d84f13 to 97d5ec3 Compare March 1, 2024 23:10
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jmdeal jmdeal merged commit 4b1d4e6 into aws:main Mar 1, 2024
17 checks passed
jmdeal added a commit to jmdeal/karpenter-provider-aws that referenced this pull request Mar 18, 2024
@jmdeal jmdeal deleted the skip-cleanup-unhealthy-nodes branch May 9, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants