Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add bottlerocket support for kubeletconfiguration evictionsoft #6760

Closed
wants to merge 10 commits into from
Closed

chore: add bottlerocket support for kubeletconfiguration evictionsoft #6760

wants to merge 10 commits into from

Conversation

anandg112
Copy link

@anandg112 anandg112 commented Aug 15, 2024 •
edited
Loading

Fixes #4271

Description

This MR adds bottlerocket support for kubeletConfiguration.evictionSoft setting.

How was this change tested?
Added functional and E2E tests for the change

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@anandg112 anandg112 requested a review from a team as a code owner August 15, 2024 00:21
@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 4450caf
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66f98db2830d760008f3b9e4
😎 Deploy Preview https://deploy-preview-6760--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@anandg112
Copy link
Author

I am a new contributor to Karpenter. Please let me know if there are any changes you would like me to make before this PR can be merged!

@ecerulm ecerulm mentioned this pull request Aug 16, 2024
Open
jonathan-innis
jonathan-innis reviewed Aug 18, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM on implementation

pkg/providers/amifamily/bootstrap/bottlerocket.go Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10396617206

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 79.32%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/providers/amifamily/bootstrap/bottlerocket.go 1 3 33.33%
Totals Coverage Status
Change from base Build 10396139252: -0.007%
Covered Lines: 5922
Relevant Lines: 7466
💛 - Coveralls

jonathan-innis
jonathan-innis reviewed Aug 28, 2024
View reviewed changes
test/suites/ami/suite_test.go
@@ -282,6 +282,7 @@ var _ = Describe("AMI", func() {
actualUserData, err := base64.StdEncoding.DecodeString(*getInstanceAttribute(pod.Spec.NodeName, "userData").UserData.Value)
Expect(err).ToNot(HaveOccurred())
Expect(string(actualUserData)).To(ContainSubstring("kube-api-qps = 30"))
Expect(string(actualUserData)).To(ContainSubstring("memory.available = 300Mi"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we validate that we this value is assigned to the eviction soft section? As it stands, this check would pass if we passed the same key to eviction hard

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the E2E integration test as requested, please review at your convenience, thx!

@renan
Copy link

renan commented Aug 30, 2024

It would be great if this merge request were expanded to support the evictionSoftGracePeriod settings as well. This would give us much more finer control over evictions and their times when using Bottlerocket.

@anandg112
Copy link
Author

It would be great if this merge request were expanded to support the evictionSoftGracePeriod settings as well. This would give us much more finer control over evictions and their times when using Bottlerocket.

I can do that in a follow-up MR

@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@github-actions github-actions bot closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 is a code owner automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
lifecycle/closed lifecycle/stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Bottlerocket support for kubeletConfiguration.evictionSoft
4 participants
@anandg112 @coveralls @renan @jonathan-innis