chore: add bottlerocket support for kubeletconfiguration evictionsoft #6760
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I am a new contributor to Karpenter. Please let me know if there are any changes you would like me to make before this PR can be merged! |
Pull Request Test Coverage Report for Build 10396617206Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
| @@ -282,6 +282,7 @@ var _ = Describe("AMI", func() { | |||
| actualUserData, err := base64.StdEncoding.DecodeString(*getInstanceAttribute(pod.Spec.NodeName, "userData").UserData.Value) | |||
| Expect(err).ToNot(HaveOccurred()) | |||
| Expect(string(actualUserData)).To(ContainSubstring("kube-api-qps = 30")) | |||
| Expect(string(actualUserData)).To(ContainSubstring("memory.available = 300Mi")) | |||
There was a problem hiding this comment.
Can we validate that we this value is assigned to the eviction soft section? As it stands, this check would pass if we passed the same key to eviction hard
There was a problem hiding this comment.
Added the E2E integration test as requested, please review at your convenience, thx!
|
It would be great if this merge request were expanded to support the |
I can do that in a follow-up MR |
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #4271
Description
This MR adds bottlerocket support for
kubeletConfiguration.evictionSoftsetting.How was this change tested?
Added functional and E2E tests for the change
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.