fix(lists): make additionally rendered items less error prone #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierpo
force-pushed
the
fix/clearer-additional-items-to-render
branch
from
d22488a
to
d38ae47
Compare
Before this change, putting 1 as additionnally rendered items would crash the list. The minimum was 2 and it is not very explicit. Now, minimum is 0, and default is 2. This is breaking change because it shifts the additionaNumberOfItemsRendered value by 2.
pierpo
force-pushed
the
fix/clearer-additional-items-to-render
branch
from
d38ae47
to
3361881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.