Fix: duplicated newlines when using dictation on iOS 18+. #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgemanrubia
force-pushed
the
fix-ios-dictation-newlines
branch
3 times, most recently
from
237205b
to
b3390da
Compare
jorgemanrubia
force-pushed
the
fix-ios-dictation-newlines
branch
4 times, most recently
from
effdb1b
to
29212fd
Compare
jorgemanrubia
force-pushed
the
fix-ios-dictation-newlines
branch
2 times, most recently
from
08fd174
to
cd64200
Compare
jorgemanrubia
force-pushed
the
fix-ios-dictation-newlines
branch
from
cd64200
to
f98e336
Compare
This fixes a bug that started to happen with iOS 18, where you would get duplicated newlines after completing the dictation. The bug happens because, upon dictation completion, iOS sends the sequence of `beforeinput` events very quickly. With the `insertParagraph` ones, it can happen that the internal document range fails to update, resulting in duplicated newlines and missed content. This workaround is necessary due to the inability to distinguish text entered in dictation mode, as iOS WebKit doesn’t trigger composition events during dictation (https://bugs.webkit.org/show_bug.cgi?id=261764).
jorgemanrubia
force-pushed
the
fix-ios-dictation-newlines
branch
from
f98e336
to
c681258
Compare
jorgemanrubia
commented
Oct 29, 2024
|
|
||
| if (handler) { | ||
| this.withEvent(event, handler) | ||
| this.scheduleRender() | ||
|
|
||
| if (!immmediateRender) { |
There was a problem hiding this comment.
I'm conservatively applying the patch to only iOS and only in certain scenarios. It would be simpler to just render things synchronously all the times. We should probably just always render synchronously if more of these show up. Scheduled rendering waits for an animation frame to render, which is good to avoid locking screen rendering, but it's problematic when receiving many events in a very quick sequence.
jorgemanrubia
added a commit
to basecamp/rails
that referenced
this pull request
Oct 30, 2024
This updates Trix to 2.1.8, which includes a patch for a dictation issue in iOS 18+ where it garbles newlines when dictation ends. See basecamp/trix#1196
jeremy
pushed a commit
to rails/rails
that referenced
this pull request
Oct 30, 2024
This updates Trix to 2.1.8, which includes a patch for a dictation issue in iOS 18+ where it garbles newlines when dictation ends. See basecamp/trix#1196
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: duplicated newlines when using dictation on iOS 18+.
This fixes a bug that started to happen with iOS 18, where you would get duplicated newlines
after completing the dictation.
The bug happens because, upon dictation completion, iOS sends the sequence of
beforeinputeventsvery quickly. With the
insertParagraphones, it can happen that the internal document range failsto update, resulting in duplicated newlines and missed content.
This workaround is necessary due to the inability to distinguish text entered in dictation mode, as
iOS WebKit doesn’t trigger composition events during dictation (https://bugs.webkit.org/show_bug.cgi?id=261764).