Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: duplicated newlines when using dictation on iOS 18+. #1196

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Fix: duplicated newlines when using dictation on iOS 18+. #1196

merged 1 commit into from
Oct 30, 2024
+35 −11

Commits on Oct 28, 2024

  1. Fix: duplicated newlines when using dictation on iOS 18+. 

    This fixes a bug that started to happen with iOS 18, where you would get duplicated newlines
after completing the dictation.

The bug happens because, upon dictation completion, iOS sends the sequence of `beforeinput` events
very quickly. With the `insertParagraph` ones, it can happen that the internal document range fails
to update, resulting in duplicated newlines and missed content.

This workaround is necessary due to the inability to distinguish text entered in dictation mode, as
iOS WebKit doesn’t trigger composition events during dictation (https://bugs.webkit.org/show_bug.cgi?id=261764).
    @jorgemanrubia
    jorgemanrubia committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c681258 View commit details
    Browse the repository at this point in the history