Properly Escape Arguments to Runner #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks to successfully fix the regular expression in question and pass the appropriately-escaped string back out for consumption. |
|
+1 |
1 similar comment
|
👍 |
gcymbalski
added a commit
that referenced
this pull request
Dec 7, 2015
Properly Escape Arguments to Runner
| # So this regex finds any '"', '{', or '}' and prepends with a '\' | ||
| ESCAPED_ARGS=`echo "$@" | sed -e 's/\([{}"]\)/\\\\\1/g'` | ||
| # So this regex finds any '(', ')', "'" , '"', '{', or '}' and prepends with a '\' | ||
| ESCAPED_ARGS=$(echo "$@" | sed -e "s/\([\\\(\\\){}\"']\)/\\\\\1/g") |
There was a problem hiding this comment.
ESCAPED_ARGS=echo "$@" | sed -e 's/([\(\){}"\x27])/\\\1/g'`` should be equivalent.
The default Solaris shell only supports command substitution with backticks. The single quote character ' can be expressed in sed expressions as \x27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192