Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly Escape Arguments to Runner #193

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Properly Escape Arguments to Runner #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions priv/base/env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ check_user() {
# riak-admin bucket-type create mytype {props: {n_val: 4}}
# after the arguments were passed into the new shell during exec su
#
# So this regex finds any '"', '{', or '}' and prepends with a '\'
ESCAPED_ARGS=`echo "$@" | sed -e 's/\([{}"]\)/\\\\\1/g'`
# So this regex finds any '(', ')', "'" , '"', '{', or '}' and prepends with a '\'
ESCAPED_ARGS=$(echo "$@" | sed -e "s/\([\\\(\\\){}\"']\)/\\\\\1/g")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESCAPED_ARGS=echo "$@" | sed -e 's/([\(\){}"\x27])/\\\1/g'`` should be equivalent.

The default Solaris shell only supports command substitution with backticks. The single quote character ' can be expressed in sed expressions as \x27.


# This will drop priviledges into the runner user
# It exec's in a new shell and the current shell will exit
Expand Down