Fix gateway detail redirect #1144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automation updates
* Feature/keycloak migration (#580) * Feature/sprint 56 UI fixes (#596) * Add fixes for deleting application optimistically and preventing saves in controls dialog * Tighten up applications mocks, errors * fix email search for finding user by email * fix ns switch error * remove switchto from perm ticket * fixes for updating roles in clients (#594) Co-authored-by: Joshua Jones <joshua@general-metrics.com> * Feature/issue 237 access stale (#599) * resolve build error * fix error with upd roles * fix display_name undefined ns access * fix display_name undefined ns access * upd logging details for online migration * upd e2e keycloak with client mappers * make title required for dataset (#606) Co-authored-by: Joshua Jones <joshua@general-metrics.com>
Products page refresh (#595)
Test automation updates
fix consumer save error failed to construct formdata (#622)
Release Login Refresh Shared IdP Org Assignment
Feature/shared idp cypress (#673)
Feature/shared idp cypress (#680)
Feature/shared idp cypress (#687)
Feature/shared idp cypress (#690)
Cypress automation updates
Feature Ops Metrics
Build feeder in test same way as portal
Release 1.2.6 changes
R1.2.6 bug fixes and ns access ui upgrade
fix feeder force sync on activity
Automation scripting updates
Email edit and ops metrics fix
increase max records for query resources (#781)
Release to test - feature public key
Fix for feature 518 public keys
Cypress org admin (#823)
Cypress automation updates
ckan out of sync issue
gwa cli v2
Cypress support for gwa-cli
Cypress gwa cli (#912)
dev to test 1.2.15
Fix the test failed due to change in gwa generate-config output (#958)
aps-2198 fix npm access denied
Cypress upd dockerfile
Release 1.2.18
changes to batch loader to support quickstart guide
Sort products by name alphabetically (#1007)
Release
convert space to dash for consumer tags (#1034)
Update 02-rate-limiting.cy.ts (#1039)
release - two-tiered-hidden for API Directory
Cypress upgrades
Feature/ns to gw (#1071)
|
Why are so many old commits showing? When I run |
rustyjux
commented
Aug 20, 2024
| @@ -158,6 +158,9 @@ const NamespacesPage: React.FC = () => { | |||
| text: 'Your Organization and Business Unit will appear here', | |||
| }; | |||
| }, [namespace]); | |||
| useEffect(() => { | |||
| window.scrollTo(0, 0); | |||
| }, []); | |||
There was a problem hiding this comment.
This change is to avoid the /detail page loading scrolled down when navigated to from /list if the user has scrolled down there. Maintaining scroll is noticeable and problematic for users on smaller displays.
We could add namespace as a dependency in order to also scroll to top when changing GW using the dropdown. However, this also causes scroll to top when going back from /manager page, which seems undesirable.
In newer versions of NextJS, the default option for router.push is scroll to top (and one can easily modify it for each call) but that's a much bigger can of worms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently adding
return nullto theuseEffect()fixes the component render cycle and may be preventing the component from mounting and unmounting unpredictably before.Worked 10x in a row in
docker composewhere it was frequently failing before.🚀 Feature branch deployment: https://api-services-portal-feature-ns-to-gw-gateway-detail-redirect.apps.silver.devops.gov.bc.ca