-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gateway detail redirect #1144
Closed
Closed
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
16ecb6d
Merge pull request #581 from bcgov/dev
ikethecoder 9759c11
Merge pull request #605 from bcgov/dev
ikethecoder d4be57f
Merge pull request #611 from bcgov/dev
ikethecoder 7e4d1a9
Merge pull request #616 from bcgov/dev
ikethecoder 671b218
Merge pull request #623 from bcgov/dev
ikethecoder ff834c2
Merge pull request #670 from bcgov/dev
ikethecoder cbcac10
Merge pull request #677 from bcgov/dev
ikethecoder 67b941a
Merge pull request #681 from bcgov/dev
ikethecoder 110e90f
Merge pull request #688 from bcgov/dev
ikethecoder c1b20be
Merge pull request #691 from bcgov/dev
ikethecoder d89cd92
Merge pull request #704 from bcgov/dev
ikethecoder 5303314
Merge pull request #706 from bcgov/dev
ikethecoder 2cbdd3e
Merge pull request #707 from bcgov/dev
ikethecoder d0d8ab2
Merge pull request #723 from bcgov/dev
ikethecoder 89e4bf4
Merge pull request #759 from bcgov/dev
ikethecoder bed9a70
Merge pull request #763 from bcgov/dev
ikethecoder e3bf9bb
Merge pull request #774 from bcgov/dev
ikethecoder c227da7
Merge pull request #778 from bcgov/dev
ikethecoder fe74bcd
Merge pull request #782 from bcgov/dev
ikethecoder f4a6ff0
Merge pull request #807 from bcgov/dev
ikethecoder 13035f4
Merge pull request #820 from bcgov/dev
ikethecoder b236ea7
Merge pull request #826 from bcgov/dev
ikethecoder 42cfcc7
Merge pull request #835 from bcgov/dev
ikethecoder 9301fd1
Merge pull request #849 from bcgov/dev
ikethecoder a09f38c
Merge pull request #897 from bcgov/dev
ikethecoder 359f97c
Merge pull request #907 from bcgov/dev
ikethecoder 3077112
Merge pull request #914 from bcgov/dev
ikethecoder d6f212a
Merge pull request #955 from bcgov/dev
Elson9 336178f
Merge pull request #959 from bcgov/dev
ikethecoder 29fbea3
Merge pull request #963 from bcgov/dev
ikethecoder a070d5f
Merge pull request #971 from bcgov/dev
ikethecoder c3d417a
Merge branch 'dev' into test
ikethecoder bd8e74f
Merge branch 'dev' into test
ikethecoder 859778b
Merge pull request #999 from bcgov/dev
rustyjux e67727f
Merge pull request #1004 from bcgov/dev
ikethecoder 2e40387
Merge pull request #1008 from bcgov/dev
ikethecoder 7b1cf07
Merge pull request #1030 from bcgov/dev
ikethecoder e6f4b9b
Merge pull request #1035 from bcgov/dev
ikethecoder e61cbee
Merge pull request #1040 from bcgov/dev
ikethecoder a9958fd
Merge pull request #1042 from bcgov/dev
rustyjux 12edc4b
Merge pull request #1055 from bcgov/dev
ikethecoder b902ab0
Merge pull request #1134 from bcgov/dev
rustyjux 4c25e6d
isolate test to check redirect
rustyjux 80ca09d
add return null
rustyjux 01a526e
remove extra tests
rustyjux ee7bdef
scroll to top of details on nav from /list
rustyjux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,3 @@ | ||
import { report } from 'process' | ||
import NameSpacePage from '../../pageObjects/namespace' | ||
let gateways: any | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is to avoid the /detail page loading scrolled down when navigated to from /list if the user has scrolled down there. Maintaining scroll is noticeable and problematic for users on smaller displays.
We could add
namespace
as a dependency in order to also scroll to top when changing GW using the dropdown. However, this also causes scroll to top when going back from /manager page, which seems undesirable.In newer versions of NextJS, the default option for router.push is scroll to top (and one can easily modify it for each call) but that's a much bigger can of worms.