feat!: authorization support for some (mostly "Bento Public") endpoints #529
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #529 +/- ##
===========================================
+ Coverage 88.63% 89.43% +0.80%
===========================================
Files 131 134 +3
Lines 4830 5094 +264
Branches 714 748 +34
===========================================
+ Hits 4281 4556 +275
+ Misses 395 386 -9
+ Partials 154 152 -2 ☔ View full report in Codecov by Sentry. |
test: test refactoring + testing of more discovery responses
|
@v-rocheleau still work to be done, but requesting an initial look at this code |
…d-scope-class refact(discovery)!: introduce container class for discovery scope
| discovery: DiscoveryConfig, | ||
| request: DrfRequest, | ||
| dt_permissions: DataTypeDiscoveryPermissions, | ||
| queryset: QuerySet, | ||
| scope_repr: str, # We pass disc |
There was a problem hiding this comment.
discovery and scope_repr arguments are derived from the same ValidatedDiscoveryScope instance.
Might be better to replace those 2 params with a single ValidatedDiscoveryScope param, otherwise someone could theoretically pass a discovery and scope_repr that don't belong together.
There was a problem hiding this comment.
this was to avoid having to deal with EmptyConfig type in two places, since scopes can return empty configs. but yeah, i agree this also isn't the best (and the comment is truncated/unfinished)
No description provided.