Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: authorization support for some (mostly "Bento Public") endpoints #529

Merged
merged 71 commits into from
Sep 9, 2024
Merged

feat!: authorization support for some (mostly "Bento Public") endpoints #529

merged 71 commits into from
Sep 9, 2024

Commits on Aug 5, 2024

  1. feat(authz): add authz submodule + middleware class

    @davidlougheed
    davidlougheed committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    3ad923b View commit details
    Browse the repository at this point in the history

  2. fix(discovery): some type hinting/exports for model lookup related code

    @davidlougheed
    davidlougheed committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    84253b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. refact: initial (partial) authz porting

    @davidlougheed
    davidlougheed committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    a069a0d View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. feat!: permissions for public filtering endpoint + consolidate with b… 

    …eacon
    @davidlougheed
    davidlougheed committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6aa9aef View commit details
    Browse the repository at this point in the history

  2. test: replace some status codes with constants

    @davidlougheed
    davidlougheed committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    e92c136 View commit details
    Browse the repository at this point in the history

  3. lint(discovery): properly mark None as allowed for discovery param

    @davidlougheed
    davidlougheed committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    204dc4f View commit details
    Browse the repository at this point in the history

  4. chore(authz): allow more authz-enabled endpoints

    @davidlougheed
    davidlougheed committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    44f4c9a View commit details
    Browse the repository at this point in the history

  5. refact(authz): more work on authz support for public endpoints

    @davidlougheed
    davidlougheed committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6313fd7 View commit details
    Browse the repository at this point in the history

  6. more work on authz impl

    @davidlougheed
    davidlougheed committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    2a12a9e View commit details
    Browse the repository at this point in the history

  7. chore: clean up unneeded diff

    @davidlougheed
    davidlougheed committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4a1ff24 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. fix(discovery): handle UUID errors from discovery get

    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    db0766d View commit details
    Browse the repository at this point in the history

  2. lint(authz): rm unused helper functions (might be reverted for future… 

    … use)
    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    003a61c View commit details
    Browse the repository at this point in the history

  3. refact: discovery overview 403 

    test: test refactoring + testing of more discovery responses
    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cddfb75 View commit details
    Browse the repository at this point in the history

  4. lint(chord): rm unused code

    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5eea18d View commit details
    Browse the repository at this point in the history

  5. test(chord): more testing of API error cases

    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3b16614 View commit details
    Browse the repository at this point in the history

  6. refact(chord): simplify some code in views_data_types

    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b21c250 View commit details
    Browse the repository at this point in the history

  7. refact!(chord): tweaks and tests for dataset data type summary

    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    79905ff View commit details
    Browse the repository at this point in the history

  8. lint

    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    dcf77bd View commit details
    Browse the repository at this point in the history

  9. perf(chord): parallelize dataset data type summary response

    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    f78ec9b View commit details
    Browse the repository at this point in the history

  10. refact: consolidate permissions defs to authz module

    @davidlougheed
    davidlougheed committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    fb36b65 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. feat(chord): handle dataset not existing/validation error for dataset… 

    … data type
    @davidlougheed
    davidlougheed committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    21f8d0f View commit details
    Browse the repository at this point in the history

  2. chore: CORS config

    @davidlougheed
    davidlougheed committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    920b156 View commit details
    Browse the repository at this point in the history

  3. feat: true counts even with 0 individuals with query data perms

    @davidlougheed
    davidlougheed committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    1155a16 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge remote-tracking branch 'origin/develop' into feat/partial-auth-… 

    …middleware
    @davidlougheed
    davidlougheed committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    0d1c7f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. fix: rm project and dataset from public search query params

    @davidlougheed
    davidlougheed committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    cf58ae8 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'develop' into feat/partial-auth-middleware

    @davidlougheed
    davidlougheed committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    469f38d View commit details
    Browse the repository at this point in the history

  2. test: test more authz conditions + refact some endpoint tests

    @davidlougheed
    davidlougheed committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    619fbaf View commit details
    Browse the repository at this point in the history

  3. chore(discovery): rm unused code

    @davidlougheed
    davidlougheed committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    9c586ae View commit details
    Browse the repository at this point in the history

  4. test(chord): project update tests

    @davidlougheed
    davidlougheed committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6cd531c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. chore(authz): comment note about middlware request patterns

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    54482fb View commit details
    Browse the repository at this point in the history

  2. lint(authz): rm unused type def

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    3821482 View commit details
    Browse the repository at this point in the history

  3. test(chord): add delete dataset tests

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    acd1057 View commit details
    Browse the repository at this point in the history

  4. test(chord): rename Bento dataset api tests

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0b1edf7 View commit details
    Browse the repository at this point in the history

  5. test(chord): use PhenoTestCase for DataTypeHelperTest

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    09bc3e4 View commit details
    Browse the repository at this point in the history

  6. test(authz): rename param for authz helpers to be more useful

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b32cae9 View commit details
    Browse the repository at this point in the history

  7. test(chord): dataset update tests

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    fc60174 View commit details
    Browse the repository at this point in the history

  8. test: factor out authorized request-making

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    539fa91 View commit details
    Browse the repository at this point in the history

  9. refact(chord): remove unused class CHORDModelViewSet

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    56a2c30 View commit details
    Browse the repository at this point in the history

  10. chore(chord)!: dataset project cannot change 

    BREAKING CHANGE: behaviour + consistent bad request responses
    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    34d3cb0 View commit details
    Browse the repository at this point in the history

  11. fix(discovery): proper check for counts permission 

    test(discovery): forbidden errors for public search
    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    7b9d958 View commit details
    Browse the repository at this point in the history

  12. test(discovery): public search error where project does not exist

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    451c377 View commit details
    Browse the repository at this point in the history

  13. test(discovery): fix test for project/dataset not existing

    @davidlougheed
    davidlougheed committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    eb10501 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. test: factor out helper for authz async delete

    @davidlougheed
    davidlougheed committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    07ead52 View commit details
    Browse the repository at this point in the history

  2. lint: rm outdated comment + expand on another comment 

    (addresses review points)
    @davidlougheed
    davidlougheed committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    8ca7c4a View commit details
    Browse the repository at this point in the history

  3. chore(discovery): comment to clarify max query params check

    @davidlougheed
    davidlougheed committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    5401cc7 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. chore(discovery): log scope for public overview query

    @davidlougheed
    davidlougheed committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    f2cb8d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. refact(discovery): introduce container class for discovery scope

    @davidlougheed
    davidlougheed committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9e03bc4 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. chore(discovery): clean up un-needed get_discovery_scope variable

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    d4a2b73 View commit details
    Browse the repository at this point in the history

  2. test(discovery): fix name of helper fn for test discovery configs

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f513614 View commit details
    Browse the repository at this point in the history

  3. chore(discovery): clean up exception-handling response logic

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4347195 View commit details
    Browse the repository at this point in the history

  4. chore(chord): handle dataset fetching errs for summary endpoint

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9ab2fdd View commit details
    Browse the repository at this point in the history

  5. chore(chord): consistent error handling for not founds/bad reqs

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5f2fd6f View commit details
    Browse the repository at this point in the history

  6. lint(chord): rm dead code

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    74c3bb7 View commit details
    Browse the repository at this point in the history

  7. refact(chord): use scope obj in 2 more places

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    98426f8 View commit details
    Browse the repository at this point in the history

  8. chore(discovery): ValidatedDiscoveryScope - check dataset parent project

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    155d9ec View commit details
    Browse the repository at this point in the history

  9. Merge pull request #531 from bento-platform/refact/discovery/validate… 

    …d-scope-class

refact(discovery)!: introduce container class for discovery scope
    @davidlougheed
    davidlougheed authored Sep 4, 2024
    Configuration menu
    Copy the full SHA
    248d77c View commit details
    Browse the repository at this point in the history

  10. refact(discovery): rm pointless async getter for scope discovery config

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    86c53f4 View commit details
    Browse the repository at this point in the history

  11. refact(discovery): use scope instead of 3 params in summary stats

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    95b3ca7 View commit details
    Browse the repository at this point in the history

  12. refact: enforce scope in summary endpoints + restructure stats code

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    a10ffe4 View commit details
    Browse the repository at this point in the history

  13. test(discovery): implement subtests in more places

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    16dfb7c View commit details
    Browse the repository at this point in the history

  14. refact(discovery): factor out scoping public model querysets

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6c60dfe View commit details
    Browse the repository at this point in the history

  15. fix: address testing inside container issue

    @davidlougheed
    davidlougheed committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    4333aee View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. lint(chord): clean up imports

    @davidlougheed
    davidlougheed committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    0b39b6b View commit details
    Browse the repository at this point in the history

  2. test(discovery): filtering public individuals by dataset

    @davidlougheed
    davidlougheed committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    b046774 View commit details
    Browse the repository at this point in the history

  3. refact(discovery): better + compound types for optional discovery config

    @davidlougheed
    davidlougheed committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    59f5dec View commit details
    Browse the repository at this point in the history

  4. fix(discovery): handle missing permissions case for public-search-fields

    @davidlougheed
    davidlougheed committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    22a7154 View commit details
    Browse the repository at this point in the history

  5. chore: clarifying comment [no ci]

    @davidlougheed
    davidlougheed committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    cf3219a View commit details
    Browse the repository at this point in the history

  6. test(chord): invalid DATS dataset update

    @davidlougheed
    davidlougheed committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    99f2bea View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. test(experiments): experiment summary scoping

    @davidlougheed
    davidlougheed committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    80a3e45 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. fix: summaries select_related

    @davidlougheed
    davidlougheed committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    250edb5 View commit details
    Browse the repository at this point in the history

  2. refact(discovery): handle empty discovery config better for /public

    @davidlougheed
    davidlougheed committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a7b7a5f View commit details
    Browse the repository at this point in the history